From: Ioana Ciornei <ciorneiioana@gmail.com>
To: linux-iio@vger.kernel.org, jic23@kernel.org
Cc: outreachy-kernel@googlegroups.com,
Ioana Ciornei <ciorneiioana@gmail.com>
Subject: [PATCH 2/2] iio: imu: check sscanf return value
Date: Sun, 1 Nov 2015 14:58:45 +0200 [thread overview]
Message-ID: <1446382725-11765-2-git-send-email-ciorneiioana@gmail.com> (raw)
In-Reply-To: <1446382725-11765-1-git-send-email-ciorneiioana@gmail.com>
This patch fixes the following checkpatch warning:
WARNING: unchecked sscanf return value
Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
---
based on linux-iio testing branch
drivers/iio/imu/adis16400_core.c | 6 +++++-
drivers/iio/imu/adis16480.c | 4 +++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
index abc4c50..72bcc24 100644
--- a/drivers/iio/imu/adis16400_core.c
+++ b/drivers/iio/imu/adis16400_core.c
@@ -288,7 +288,11 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev)
if (ret)
goto err_ret;
- sscanf(indio_dev->name, "adis%u\n", &device_id);
+ ret = sscanf(indio_dev->name, "adis%u\n", &device_id);
+ if (ret != 1) {
+ ret = -EINVAL;
+ goto err_ret;
+ }
if (prod_id != device_id)
dev_warn(&indio_dev->dev, "Device ID(%u) and product ID(%u) do not match.",
diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
index b94bfd3..16d4304 100644
--- a/drivers/iio/imu/adis16480.c
+++ b/drivers/iio/imu/adis16480.c
@@ -765,7 +765,9 @@ static int adis16480_initial_setup(struct iio_dev *indio_dev)
if (ret)
return ret;
- sscanf(indio_dev->name, "adis%u\n", &device_id);
+ ret = sscanf(indio_dev->name, "adis%u\n", &device_id);
+ if (ret != 1)
+ return -EINVAL;
if (prod_id != device_id)
dev_warn(&indio_dev->dev, "Device ID(%u) and product ID(%u) do not match.",
--
2.1.4
next prev parent reply other threads:[~2015-11-01 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 12:58 [PATCH 1/2] iio: gyro: check sscanf return value Ioana Ciornei
2015-11-01 12:58 ` Ioana Ciornei [this message]
2015-11-08 15:45 ` [PATCH 2/2] iio: imu: " Jonathan Cameron
2015-11-01 18:17 ` [PATCH 1/2] iio: gyro: " Jonathan Cameron
2015-11-01 20:08 ` Ioana Ciornei
2015-11-03 9:22 ` Lars-Peter Clausen
2015-11-08 15:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446382725-11765-2-git-send-email-ciorneiioana@gmail.com \
--to=ciorneiioana@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox