Re: [PATCH 2/2] iio: imu: check sscanf return value

[Jonathan Cameron <jic23@kernel.org>]

On 01/11/15 12:58, Ioana Ciornei wrote:
> This patch fixes the following checkpatch warning:
> WARNING: unchecked sscanf return value
> 
> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Applied to the togreg branch of stating - initially pushed
out as testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> 
> based on linux-iio testing branch
> 
>  drivers/iio/imu/adis16400_core.c | 6 +++++-
>  drivers/iio/imu/adis16480.c      | 4 +++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/adis16400_core.c b/drivers/iio/imu/adis16400_core.c
> index abc4c50..72bcc24 100644
> --- a/drivers/iio/imu/adis16400_core.c
> +++ b/drivers/iio/imu/adis16400_core.c
> @@ -288,7 +288,11 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev)
>  		if (ret)
>  			goto err_ret;
>  
> -		sscanf(indio_dev->name, "adis%u\n", &device_id);
> +		ret = sscanf(indio_dev->name, "adis%u\n", &device_id);
> +		if (ret != 1) {
> +			ret = -EINVAL;
> +			goto err_ret;
> +		}
>  
>  		if (prod_id != device_id)
>  			dev_warn(&indio_dev->dev, "Device ID(%u) and product ID(%u) do not match.",
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index b94bfd3..16d4304 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -765,7 +765,9 @@ static int adis16480_initial_setup(struct iio_dev *indio_dev)
>  	if (ret)
>  		return ret;
>  
> -	sscanf(indio_dev->name, "adis%u\n", &device_id);
> +	ret = sscanf(indio_dev->name, "adis%u\n", &device_id);
> +	if (ret != 1)
> +		return -EINVAL;
>  
>  	if (prod_id != device_id)
>  		dev_warn(&indio_dev->dev, "Device ID(%u) and product ID(%u) do not match.",
>