Work plan to move meter out of staging

Work plan to move meter out of staging

[Rodrigo Siqueira]

Hi,

Recently, I started to work on IIO subsystem, and I already have sent some
patches. Now, I want to move to the next step by working for helping to push
the meter module out of staging.

In this sense, I am planning to do the following tasks:

1) Make meter checkpatch free

I already made some checkpatch cleanups in this module, but it still have some
tiny things to fix. I already start to work on this task, and I will send a
patch series this week with the checkpatch fixes.

2) Code cleanups

I noticed the code has some duplications and utilizes many magic numbers which
make difficult to read the code. In order to attempt to improve the code
readability, I am planning to work on the following tasks:

* Part of the code that I believe that has some duplications that could be
  generalized:
 - ade7753_spi_write_reg_[0-9]+
 - ade7753_read_[0-9]+bit
 - ade7753_write_[0-9]+bit
 - ade7758_spi_write_reg_[0-9]+
 - ade7758_spi_read_reg_[0-9]+
 - ade7758_spi_read_[0-9]+bit
 - ade7758_spi_write_[0-9]+bit
 - ade7759_spi_read_reg_[0-9]+

* I believe there is a vast number of macro that could be removed because it is
  used one or three times in the whole code. I think the direct use of
  IIO_DEVICE_ATTR can be better in these cases. This changes can solve some
  checkpatch problems, and improve the readability.

* There are some magic numbers that I believe that came from the datasheet. I
  think that it is possible to use some defines to improve the readability in
  these cases.

3) Missing code

These parts look much more fun to work. However, I do not fully understand the
IIO subsystem yet, and maybe I say something that does not make sense. So, If I
say something that does not make sense, please let me know.

So, I believe the meter module still need some pieces of code. For example:

* ade7754, ade7759, ade7854 - It does not have iio_chan_spec and
        											*_read_raw/*_write_raw

* ade7758 - *_read_raw looks incomplete.


That's it.
Is my work plan to move meter out of staging make sense?

Thanks

Re: Work plan to move meter out of staging

[Daniel Baluta]

DQpPbiBMdSwgMjAxOC0wMy0wNSBhdCAxMTowMiAtMDMwMCwgUm9kcmlnbyBTaXF1ZWlyYSB3cm90
ZToNCj4gSGksDQo+IA0KPiBSZWNlbnRseSwgSSBzdGFydGVkIHRvIHdvcmsgb24gSUlPIHN1YnN5
c3RlbSwgYW5kIEkgYWxyZWFkeSBoYXZlIHNlbnQgc29tZQ0KPiBwYXRjaGVzLiBOb3csIEkgd2Fu
dCB0byBtb3ZlIHRvIHRoZSBuZXh0IHN0ZXAgYnkgd29ya2luZyBmb3IgaGVscGluZyB0byBwdXNo
DQo+IHRoZSBtZXRlciBtb2R1bGUgb3V0IG9mIHN0YWdpbmcuDQo+IA0KPiBJbiB0aGlzIHNlbnNl
LCBJIGFtIHBsYW5uaW5nIHRvIGRvIHRoZSBmb2xsb3dpbmcgdGFza3M6DQo+IA0KPiAxKSBNYWtl
IG1ldGVyIGNoZWNrcGF0Y2ggZnJlZQ0KPiANCj4gSSBhbHJlYWR5IG1hZGUgc29tZSBjaGVja3Bh
dGNoIGNsZWFudXBzIGluIHRoaXMgbW9kdWxlLCBidXQgaXQgc3RpbGwgaGF2ZSBzb21lDQo+IHRp
bnkgdGhpbmdzIHRvIGZpeC4gSSBhbHJlYWR5IHN0YXJ0IHRvIHdvcmsgb24gdGhpcyB0YXNrLCBh
bmQgSSB3aWxsIHNlbmQgYQ0KPiBwYXRjaCBzZXJpZXMgdGhpcyB3ZWVrIHdpdGggdGhlIGNoZWNr
cGF0Y2ggZml4ZXMuDQo+IA0KPiAyKSBDb2RlIGNsZWFudXBzDQo+IA0KPiBJIG5vdGljZWQgdGhl
IGNvZGUgaGFzIHNvbWUgZHVwbGljYXRpb25zIGFuZCB1dGlsaXplcyBtYW55IG1hZ2ljIG51bWJl
cnMgd2hpY2gNCj4gbWFrZSBkaWZmaWN1bHQgdG8gcmVhZCB0aGUgY29kZS4gSW4gb3JkZXIgdG8g
YXR0ZW1wdCB0byBpbXByb3ZlIHRoZSBjb2RlDQo+IHJlYWRhYmlsaXR5LCBJIGFtIHBsYW5uaW5n
IHRvIHdvcmsgb24gdGhlIGZvbGxvd2luZyB0YXNrczoNCj4gDQo+ICogUGFydCBvZiB0aGUgY29k
ZSB0aGF0IEkgYmVsaWV2ZSB0aGF0IGhhcyBzb21lIGR1cGxpY2F0aW9ucyB0aGF0IGNvdWxkIGJl
DQo+IMKgIGdlbmVyYWxpemVkOg0KPiDCoC0gYWRlNzc1M19zcGlfd3JpdGVfcmVnX1swLTldKw0K
PiDCoC0gYWRlNzc1M19yZWFkX1swLTldK2JpdA0KPiDCoC0gYWRlNzc1M193cml0ZV9bMC05XSti
aXQNCj4gwqAtIGFkZTc3NThfc3BpX3dyaXRlX3JlZ19bMC05XSsNCj4gwqAtIGFkZTc3NThfc3Bp
X3JlYWRfcmVnX1swLTldKw0KPiDCoC0gYWRlNzc1OF9zcGlfcmVhZF9bMC05XStiaXQNCj4gwqAt
IGFkZTc3NThfc3BpX3dyaXRlX1swLTldK2JpdA0KPiDCoC0gYWRlNzc1OV9zcGlfcmVhZF9yZWdf
WzAtOV0rDQo+IA0KPiAqIEkgYmVsaWV2ZSB0aGVyZSBpcyBhIHZhc3QgbnVtYmVyIG9mIG1hY3Jv
IHRoYXQgY291bGQgYmUgcmVtb3ZlZCBiZWNhdXNlIGl0IGlzDQo+IMKgIHVzZWQgb25lIG9yIHRo
cmVlIHRpbWVzIGluIHRoZSB3aG9sZSBjb2RlLiBJIHRoaW5rIHRoZSBkaXJlY3QgdXNlIG9mDQo+
IMKgIElJT19ERVZJQ0VfQVRUUiBjYW4gYmUgYmV0dGVyIGluIHRoZXNlIGNhc2VzLiBUaGlzIGNo
YW5nZXMgY2FuIHNvbHZlIHNvbWUNCj4gwqAgY2hlY2twYXRjaCBwcm9ibGVtcywgYW5kIGltcHJv
dmUgdGhlIHJlYWRhYmlsaXR5Lg0KPiANCj4gKiBUaGVyZSBhcmUgc29tZSBtYWdpYyBudW1iZXJz
IHRoYXQgSSBiZWxpZXZlIHRoYXQgY2FtZSBmcm9tIHRoZSBkYXRhc2hlZXQuIEkNCj4gwqAgdGhp
bmsgdGhhdCBpdCBpcyBwb3NzaWJsZSB0byB1c2Ugc29tZSBkZWZpbmVzIHRvIGltcHJvdmUgdGhl
IHJlYWRhYmlsaXR5IGluDQo+IMKgIHRoZXNlIGNhc2VzLg0KPiANCj4gMykgTWlzc2luZyBjb2Rl
DQo+IA0KPiBUaGVzZSBwYXJ0cyBsb29rIG11Y2ggbW9yZSBmdW4gdG8gd29yay4gSG93ZXZlciwg
SSBkbyBub3QgZnVsbHkgdW5kZXJzdGFuZCB0aGUNCj4gSUlPIHN1YnN5c3RlbSB5ZXQsIGFuZCBt
YXliZSBJIHNheSBzb21ldGhpbmcgdGhhdCBkb2VzIG5vdCBtYWtlIHNlbnNlLiBTbywgSWYgSQ0K
PiBzYXkgc29tZXRoaW5nIHRoYXQgZG9lcyBub3QgbWFrZSBzZW5zZSwgcGxlYXNlIGxldCBtZSBr
bm93Lg0KPiANCj4gU28sIEkgYmVsaWV2ZSB0aGUgbWV0ZXIgbW9kdWxlIHN0aWxsIG5lZWQgc29t
ZSBwaWVjZXMgb2YgY29kZS4gRm9yIGV4YW1wbGU6DQo+IA0KPiAqIGFkZTc3NTQsIGFkZTc3NTks
IGFkZTc4NTQgLSBJdCBkb2VzIG5vdCBoYXZlIGlpb19jaGFuX3NwZWMgYW5kDQo+IMKgwqDCoMKg
wqDCoMKgwqAJCQkJCQkJCQkJCSpfcmVhZF9yYXcvKl93cml0ZV9yYXcNCj4gDQo+ICogYWRlNzc1
OCAtICpfcmVhZF9yYXcgbG9va3MgaW5jb21wbGV0ZS4NCj4gDQo+IA0KPiBUaGF0J3MgaXQuDQo+
IElzIG15IHdvcmsgcGxhbiB0byBtb3ZlIG1ldGVyIG91dCBvZiBzdGFnaW5nIG1ha2Ugc2Vuc2U/
DQoNCg0KSGkgUm9kcmlnbywNCg0KVGhpcyBsb29rcyBsaWtlIGEgZ29vZCBwbGFuIHRvIG1lLsKg
DQoNCkNjLWluZyBMYXJzLCBtYXliZSB0aGV5IGhhdmUgcHJlcGFyaW5nIHNvbWV0aGluZyBhdCBB
bmFsb2cgcmVnYXJkaW5nIHRoaXMgY29kZS4NCg0KdGhhbmtzLA0KRGFuaWVsLg0K

Re: Work plan to move meter out of staging

[Lars-Peter Clausen]

Adding Michael, he coordinates the ADI Linux effort.

On 03/05/2018 03:21 PM, Daniel Baluta wrote:
> 
> On Lu, 2018-03-05 at 11:02 -0300, Rodrigo Siqueira wrote:
>> Hi,
>>
>> Recently, I started to work on IIO subsystem, and I already have sent some
>> patches. Now, I want to move to the next step by working for helping to push
>> the meter module out of staging.
>>
>> In this sense, I am planning to do the following tasks:
>>
>> 1) Make meter checkpatch free
>>
>> I already made some checkpatch cleanups in this module, but it still have some
>> tiny things to fix. I already start to work on this task, and I will send a
>> patch series this week with the checkpatch fixes.
>>
>> 2) Code cleanups
>>
>> I noticed the code has some duplications and utilizes many magic numbers which
>> make difficult to read the code. In order to attempt to improve the code
>> readability, I am planning to work on the following tasks:
>>
>> * Part of the code that I believe that has some duplications that could be
>>   generalized:
>>  - ade7753_spi_write_reg_[0-9]+
>>  - ade7753_read_[0-9]+bit
>>  - ade7753_write_[0-9]+bit
>>  - ade7758_spi_write_reg_[0-9]+
>>  - ade7758_spi_read_reg_[0-9]+
>>  - ade7758_spi_read_[0-9]+bit
>>  - ade7758_spi_write_[0-9]+bit
>>  - ade7759_spi_read_reg_[0-9]+
>>
>> * I believe there is a vast number of macro that could be removed because it is
>>   used one or three times in the whole code. I think the direct use of
>>   IIO_DEVICE_ATTR can be better in these cases. This changes can solve some
>>   checkpatch problems, and improve the readability.
>>
>> * There are some magic numbers that I believe that came from the datasheet. I
>>   think that it is possible to use some defines to improve the readability in
>>   these cases.
>>
>> 3) Missing code
>>
>> These parts look much more fun to work. However, I do not fully understand the
>> IIO subsystem yet, and maybe I say something that does not make sense. So, If I
>> say something that does not make sense, please let me know.
>>
>> So, I believe the meter module still need some pieces of code. For example:
>>
>> * ade7754, ade7759, ade7854 - It does not have iio_chan_spec and
>>         											*_read_raw/*_write_raw
>>
>> * ade7758 - *_read_raw looks incomplete.
>>
>>
>> That's it.
>> Is my work plan to move meter out of staging make sense?
> 
> 
> Hi Rodrigo,
> 
> This looks like a good plan to me. 
> 
> Cc-ing Lars, maybe they have preparing something at Analog regarding this code.
> 
> thanks,
> Daniel.
> 

Re: Work plan to move meter out of staging

[Michael Hennerich]

On 05.03.2018 17:30, Lars-Peter Clausen wrote:
> Adding Michael, he coordinates the ADI Linux effort.
> 
> On 03/05/2018 03:21 PM, Daniel Baluta wrote:
>>
>> On Lu, 2018-03-05 at 11:02 -0300, Rodrigo Siqueira wrote:
>>> Hi,
>>>
>>> Recently, I started to work on IIO subsystem, and I already have sent some
>>> patches. Now, I want to move to the next step by working for helping to push
>>> the meter module out of staging.
>>>
>>> In this sense, I am planning to do the following tasks:
>>>
>>> 1) Make meter checkpatch free
>>>
>>> I already made some checkpatch cleanups in this module, but it still have some
>>> tiny things to fix. I already start to work on this task, and I will send a
>>> patch series this week with the checkpatch fixes.
>>>
>>> 2) Code cleanups
>>>
>>> I noticed the code has some duplications and utilizes many magic numbers which
>>> make difficult to read the code. In order to attempt to improve the code
>>> readability, I am planning to work on the following tasks:
>>>
>>> * Part of the code that I believe that has some duplications that could be
>>>    generalized:
>>>   - ade7753_spi_write_reg_[0-9]+
>>>   - ade7753_read_[0-9]+bit
>>>   - ade7753_write_[0-9]+bit
>>>   - ade7758_spi_write_reg_[0-9]+
>>>   - ade7758_spi_read_reg_[0-9]+
>>>   - ade7758_spi_read_[0-9]+bit
>>>   - ade7758_spi_write_[0-9]+bit
>>>   - ade7759_spi_read_reg_[0-9]+
>>>
>>> * I believe there is a vast number of macro that could be removed because it is
>>>    used one or three times in the whole code. I think the direct use of
>>>    IIO_DEVICE_ATTR can be better in these cases. This changes can solve some
>>>    checkpatch problems, and improve the readability.
>>>
>>> * There are some magic numbers that I believe that came from the datasheet. I
>>>    think that it is possible to use some defines to improve the readability in
>>>    these cases.
>>>
>>> 3) Missing code
>>>
>>> These parts look much more fun to work. However, I do not fully understand the
>>> IIO subsystem yet, and maybe I say something that does not make sense. So, If I
>>> say something that does not make sense, please let me know.
>>>
>>> So, I believe the meter module still need some pieces of code. For example:
>>>
>>> * ade7754, ade7759, ade7854 - It does not have iio_chan_spec and
>>>          											*_read_raw/*_write_raw
>>>
>>> * ade7758 - *_read_raw looks incomplete.
>>>
>>>
>>> That's it.
>>> Is my work plan to move meter out of staging make sense?
>>
>>
>> Hi Rodrigo,
>>
>> This looks like a good plan to me.
>>
>> Cc-ing Lars, maybe they have preparing something at Analog regarding this code.
>>
>> thanks,
>> Daniel.

In general I think this is a great idea, however looking at it from a 
different angle -
Most of the supported metering circuits are already marked as not 
recommended for new designs.
While Analog Devices have a very strong product portfolio in the 
Metering IC space, all of the parts in
staging/iio/meter are from 2011 and before and have already seen 
multiple product iterations since then.
A major rework of these drivers might require testing, unfortunately 
these drivers were developed by a different team which now pursues 
different responsibilities.
So I won’t be able to test them again, and therefore I’m also a bit 
hesitant to lift them out of staging.


-- 
Greetings,
Michael

--
Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne

Re: Work plan to move meter out of staging

[Rodrigo Siqueira]

Hi,

> On 05.03.2018 17:30, Lars-Peter Clausen wrote:
> In general I think this is a great idea, however looking at it from a
> different angle -
> Most of the supported metering circuits are already marked as not
> recommended for new designs.
> While Analog Devices have a very strong product portfolio in the Metering IC
> space, all of the parts in
> staging/iio/meter are from 2011 and before and have already seen multiple
> product iterations since then.
> A major rework of these drivers might require testing, unfortunately these
> drivers were developed by a different team which now pursues different
> responsibilities.
> So I won’t be able to test them again, and therefore I’m also a bit hesitant
> to lift them out of staging.

I have seen your message a few minutes ago, just after I sent a patch
series that removes checkpatch problems from meter module. Anyway, after
your comments, I believe that is a better idea to work on another module
in the staging. Is that ok Daniel?

Just for curiosity, what is the process to remove meter from staging?

Thanks
 
> -- 
> Greetings,
> Michael
> 
> --
> Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 München
> Sitz der Gesellschaft München, Registergericht München HRB 40368,
> Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne

Re: Work plan to move meter out of staging

[Daniel Baluta]

T24gTWEsIDIwMTgtMDMtMDYgYXQgMDk6MzYgLTAzMDAsIFJvZHJpZ28gU2lxdWVpcmEgd3JvdGU6
DQo+IEhpLA0KPiANCj4gPiANCj4gPiBPbiAwNS4wMy4yMDE4IDE3OjMwLCBMYXJzLVBldGVyIENs
YXVzZW4gd3JvdGU6DQo+ID4gSW4gZ2VuZXJhbCBJIHRoaW5rIHRoaXMgaXMgYSBncmVhdCBpZGVh
LCBob3dldmVyIGxvb2tpbmcgYXQgaXQgZnJvbSBhDQo+ID4gZGlmZmVyZW50IGFuZ2xlIC0NCj4g
PiBNb3N0IG9mIHRoZSBzdXBwb3J0ZWQgbWV0ZXJpbmcgY2lyY3VpdHMgYXJlIGFscmVhZHkgbWFy
a2VkIGFzIG5vdA0KPiA+IHJlY29tbWVuZGVkIGZvciBuZXcgZGVzaWducy4NCj4gPiBXaGlsZSBB
bmFsb2cgRGV2aWNlcyBoYXZlIGEgdmVyeSBzdHJvbmcgcHJvZHVjdCBwb3J0Zm9saW8gaW4gdGhl
IE1ldGVyaW5nIElDDQo+ID4gc3BhY2UsIGFsbCBvZiB0aGUgcGFydHMgaW4NCj4gPiBzdGFnaW5n
L2lpby9tZXRlciBhcmUgZnJvbSAyMDExIGFuZCBiZWZvcmUgYW5kIGhhdmUgYWxyZWFkeSBzZWVu
IG11bHRpcGxlDQo+ID4gcHJvZHVjdCBpdGVyYXRpb25zIHNpbmNlIHRoZW4uDQo+ID4gQSBtYWpv
ciByZXdvcmsgb2YgdGhlc2UgZHJpdmVycyBtaWdodCByZXF1aXJlIHRlc3RpbmcsIHVuZm9ydHVu
YXRlbHkgdGhlc2UNCj4gPiBkcml2ZXJzIHdlcmUgZGV2ZWxvcGVkIGJ5IGEgZGlmZmVyZW50IHRl
YW0gd2hpY2ggbm93IHB1cnN1ZXMgZGlmZmVyZW50DQo+ID4gcmVzcG9uc2liaWxpdGllcy4NCj4g
PiBTbyBJIHdvbuKAmXQgYmUgYWJsZSB0byB0ZXN0IHRoZW0gYWdhaW4sIGFuZCB0aGVyZWZvcmUg
SeKAmW0gYWxzbyBhIGJpdCBoZXNpdGFudA0KPiA+IHRvIGxpZnQgdGhlbSBvdXQgb2Ygc3RhZ2lu
Zy4NCj4gSSBoYXZlIHNlZW4geW91ciBtZXNzYWdlIGEgZmV3IG1pbnV0ZXMgYWdvLCBqdXN0IGFm
dGVyIEkgc2VudCBhIHBhdGNoDQo+IHNlcmllcyB0aGF0IHJlbW92ZXMgY2hlY2twYXRjaCBwcm9i
bGVtcyBmcm9tIG1ldGVyIG1vZHVsZS4gQW55d2F5LCBhZnRlcg0KPiB5b3VyIGNvbW1lbnRzLCBJ
IGJlbGlldmUgdGhhdCBpcyBhIGJldHRlciBpZGVhIHRvIHdvcmsgb24gYW5vdGhlciBtb2R1bGUN
Cj4gaW4gdGhlIHN0YWdpbmcuIElzIHRoYXQgb2sgRGFuaWVsPw0KDQpIaSwNCg0KSSB0aGluayBp
dCBpcyBzdGlsbCBhIGdvb2QgaWRlYSB0byBtYWtlIHRoZSBjaGVja3BhdGNoIGNoYW5nZXMgaW4g
dGhlIG1ldGVyIGRpcmVjdG9yeQ0KZnJvbSBzdGFnaW5nLsKgDQo+IA0KPiBKdXN0IGZvciBjdXJp
b3NpdHksIHdoYXQgaXMgdGhlIHByb2Nlc3MgdG8gcmVtb3ZlIG1ldGVyIGZyb20gc3RhZ2luZz8N
Cg0KTWFrZSBzdXJlIHdlIHVzZSB0aGUgc3RhbmRhcmQgSUlPIGludGVyZmFjZXMsIGdvb2QgcXVh
bGl0eSBjb2RlIGFuZCBnb29kIHRlc3RpbmcgOikuDQoNCnRoYW5rcywNCkRhbmllbC4=

Re: Work plan to move meter out of staging

[Jonathan Cameron]

On 6 March 2018 13:04:31 GMT, Daniel Baluta <daniel.baluta@nxp.com> wrote:
>On Ma, 2018-03-06 at 09:36 -0300, Rodrigo Siqueira wrote:
>> Hi,
>> 
>> > 
>> > On 05.03.2018 17:30, Lars-Peter Clausen wrote:
>> > In general I think this is a great idea, however looking at it from
>a
>> > different angle -
>> > Most of the supported metering circuits are already marked as not
>> > recommended for new designs.
>> > While Analog Devices have a very strong product portfolio in the
>Metering IC
>> > space, all of the parts in
>> > staging/iio/meter are from 2011 and before and have already seen
>multiple
>> > product iterations since then.
>> > A major rework of these drivers might require testing,
>unfortunately these
>> > drivers were developed by a different team which now pursues
>different
>> > responsibilities.
>> > So I won’t be able to test them again, and therefore I’m also a bit
>hesitant
>> > to lift them out of staging.
>> I have seen your message a few minutes ago, just after I sent a patch
>> series that removes checkpatch problems from meter module. Anyway,
>after
>> your comments, I believe that is a better idea to work on another
>module
>> in the staging. Is that ok Daniel?
>
>Hi,
>
>I think it is still a good idea to make the checkpatch changes in the
>meter directory
>from staging. 
For work already done I agree but perhaps we can find a better target for effort going forward.

Michael, what is the position on the CDC drivers and the resolver ones? 

Jonathan
>> 
>> Just for curiosity, what is the process to remove meter from staging?
>
>Make sure we use the standard IIO interfaces, good quality code and
>good testing :).
>
>thanks,
>Daniel.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Re: Work plan to move meter out of staging

[Michael Hennerich]

On 06.03.2018 14:41, Jonathan Cameron wrote:
> 
> 
> On 6 March 2018 13:04:31 GMT, Daniel Baluta <daniel.baluta@nxp.com> wrote:
>> On Ma, 2018-03-06 at 09:36 -0300, Rodrigo Siqueira wrote:
>>> Hi,
>>>
>>>>
>>>> On 05.03.2018 17:30, Lars-Peter Clausen wrote:
>>>> In general I think this is a great idea, however looking at it from
>> a
>>>> different angle -
>>>> Most of the supported metering circuits are already marked as not
>>>> recommended for new designs.
>>>> While Analog Devices have a very strong product portfolio in the
>> Metering IC
>>>> space, all of the parts in
>>>> staging/iio/meter are from 2011 and before and have already seen
>> multiple
>>>> product iterations since then.
>>>> A major rework of these drivers might require testing,
>> unfortunately these
>>>> drivers were developed by a different team which now pursues
>> different
>>>> responsibilities.
>>>> So I won’t be able to test them again, and therefore I’m also a bit
>> hesitant
>>>> to lift them out of staging.
>>> I have seen your message a few minutes ago, just after I sent a patch
>>> series that removes checkpatch problems from meter module. Anyway,
>> after
>>> your comments, I believe that is a better idea to work on another
>> module
>>> in the staging. Is that ok Daniel?
>>
>> Hi,
>>
>> I think it is still a good idea to make the checkpatch changes in the
>> meter directory
>>from staging. 
> For work already done I agree but perhaps we can find a better target for effort going forward.
> 
> Michael, what is the position on the CDC drivers and the resolver ones?

The CDC and resolvers are much better targets. The products are still 
appropriate for new designs. And what the CDC drivers are concerned I 
still have HW to test.

> 
> Jonathan
>>>
>>> Just for curiosity, what is the process to remove meter from staging?
>>
>> Make sure we use the standard IIO interfaces, good quality code and
>> good testing :).
>>
>> thanks,
>> Daniel.
> 


-- 
Greetings,
Michael

--
Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne