From: David Lechner <dlechner@baylibre.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>,
jikos@kernel.org, jic23@kernel.org,
srinivas.pandruvada@linux.intel.com
Cc: nuno.sa@analog.com, andy@kernel.org,
sakari.ailus@linux.intel.com, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/9] iio: gyro: hid-sensor-gyro-3d: cleanup codestyle warning
Date: Sat, 9 May 2026 16:38:26 -0500 [thread overview]
Message-ID: <16811995-2371-4f4e-add8-76b5acc30f53@baylibre.com> (raw)
In-Reply-To: <20260509101040.791404-5-sanjayembedded@gmail.com>
On 5/9/26 5:10 AM, Sanjay Chitroda wrote:
> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>
> Reported by checkpatch:
> FILE: drivers/iio/gyro/hid-sensor-gyro-3d.c
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> + unsigned usage_id,
Even better would be to use u32 since this driver already uses
that type.
>
> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> ---
> drivers/iio/gyro/hid-sensor-gyro-3d.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> index fe663b19e902..87537f9c58fb 100644
> --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
> +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
> @@ -187,7 +187,7 @@ static const struct iio_info gyro_3d_info = {
>
> /* Callback handler to send event after all samples are received and captured */
> static int gyro_3d_proc_event(struct hid_sensor_hub_device *hsdev,
> - unsigned usage_id,
> + unsigned int usage_id,
> void *priv)
> {
> struct iio_dev *indio_dev = platform_get_drvdata(priv);
> @@ -209,7 +209,7 @@ static int gyro_3d_proc_event(struct hid_sensor_hub_device *hsdev,
>
> /* Capture samples in local storage */
> static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
> - unsigned usage_id,
> + unsigned int usage_id,
> size_t raw_len, char *raw_data,
> void *priv)
> {
> @@ -244,7 +244,7 @@ static int gyro_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
> static int gyro_3d_parse_report(struct platform_device *pdev,
> struct hid_sensor_hub_device *hsdev,
> struct iio_chan_spec *channels,
> - unsigned usage_id,
> + unsigned int usage_id,
> struct gyro_3d_state *st)
> {
> int ret;
next prev parent reply other threads:[~2026-05-09 21:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 10:10 [PATCH v3 0/9] iio: introduce devm_ API for hid sensro setup and cleanup Sanjay Chitroda
2026-05-09 10:10 ` [PATCH v3 1/9] iio: hid-sensors: drop redundant iio_dev argument Sanjay Chitroda
2026-05-09 21:32 ` David Lechner
2026-05-09 10:10 ` [PATCH v3 2/9] iio: hid-sensors: cleanup codestyle warning Sanjay Chitroda
2026-05-09 21:35 ` David Lechner
2026-05-09 10:10 ` [PATCH v3 3/9] iio: hid-sensors: introduce device managed API Sanjay Chitroda
2026-05-10 6:36 ` Andy Shevchenko
2026-05-09 10:10 ` [PATCH v3 4/9] iio: gyro: hid-sensor-gyro-3d: cleanup codestyle warning Sanjay Chitroda
2026-05-09 21:38 ` David Lechner [this message]
2026-05-10 6:38 ` Andy Shevchenko
2026-05-09 10:10 ` [PATCH v3 5/9] iio: gyro: hid-sensor-gyro-3d: drop hid_sensor_remove_trigger() using devm API Sanjay Chitroda
2026-05-09 10:10 ` [PATCH v3 6/9] iio: humidity: hid-sensor-humidity: cleanup codestyle check Sanjay Chitroda
2026-05-09 10:10 ` [PATCH v3 7/9] iio: humidity: hid-sensor-humidity: use common device for devres Sanjay Chitroda
2026-05-10 6:42 ` Andy Shevchenko
2026-05-09 10:10 ` [PATCH v3 8/9] iio: humidity: hid-sensor-humidity: use local struct device Sanjay Chitroda
2026-05-09 10:10 ` [PATCH v3 9/9] iio: humidity: hid-sensor-humidity: drop hid_sensor_remove_trigger() using devm API Sanjay Chitroda
2026-05-09 21:44 ` [PATCH v3 0/9] iio: introduce devm_ API for hid sensro setup and cleanup David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16811995-2371-4f4e-add8-76b5acc30f53@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andy@kernel.org \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sanjayembeddedse@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox