public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: wangshuaijie@awinic.com
Cc: conor+dt@kernel.org, linux-kernel@vger.kernel.org,
	lars@metafoo.de,  linux-iio@vger.kernel.org, liweilei@awinic.com,
	waqar.hameed@axis.com,  kangjiajun@awinic.com,
	devicetree@vger.kernel.org, krzk+dt@kernel.org,
	 jic23@kernel.org
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor
Date: Fri, 12 Jul 2024 06:34:18 -0600	[thread overview]
Message-ID: <172078765827.447376.17487276734407379568.robh@kernel.org> (raw)
In-Reply-To: <20240712113200.2468249-2-wangshuaijie@awinic.com>


On Fri, 12 Jul 2024 11:31:59 +0000, wangshuaijie@awinic.com wrote:
> From: shuaijie wang <wangshuaijie@awinic.com>
> 
> Add the awinic,aw96xxx.yaml file to adapt to the awinic proximity sensor driver.
> Addressing the issues raised in the previous version.
> 1. Add a description about the hardware device.
> 2. Remove inappropriate configuration items.
> 3. Modify the formatting issues.
> 
> Signed-off-by: shuaijie wang <wangshuaijie@awinic.com>
> ---
>  .../iio/proximity/awinic,aw96xxx.yaml         | 127 ++++++++++++++++++
>  1 file changed, 127 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml:50:49: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.example.dts'
Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml:50:49: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml:50:49: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw96xxx.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240712113200.2468249-2-wangshuaijie@awinic.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-07-12 12:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 11:31 [PATCH V3 0/2] Add support for Awinic SAR sensor wangshuaijie
2024-07-12 11:31 ` [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor wangshuaijie
2024-07-12 11:55   ` Krzysztof Kozlowski
2024-07-13 12:15     ` Jonathan Cameron
2024-07-25 12:47     ` wangshuaijie
2024-07-25 13:53       ` Krzysztof Kozlowski
2024-07-12 12:34   ` Rob Herring (Arm) [this message]
2024-07-12 11:32 ` [PATCH V3 2/2] Add support for " wangshuaijie
2024-07-12 12:01   ` Krzysztof Kozlowski
2024-07-25 12:48     ` wangshuaijie
2024-07-12 14:33   ` Markus Elfring
2024-07-12 22:22   ` kernel test robot
2024-07-13  6:15   ` kernel test robot
2024-07-13  8:50   ` kernel test robot
2024-07-13 10:33   ` kernel test robot
2024-07-13 14:27   ` Jonathan Cameron
2024-07-25 12:47     ` wangshuaijie
2024-07-27 12:22       ` Jonathan Cameron
2024-07-12 11:49 ` [PATCH V3 0/2] Add support for Awinic SAR sensor Waqar Hameed
2024-07-25 12:48   ` wangshuaijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172078765827.447376.17487276734407379568.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kangjiajun@awinic.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liweilei@awinic.com \
    --cc=wangshuaijie@awinic.com \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox