public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: shuaijie wang <wangshuaijie@awinic.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	Waqar Hameed <waqar.hameed@axis.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kangjiajun@awinic.com, Nick Li <liweilei@awinic.com>
Subject: Re: [PATCH V3 2/2] Add support for Awinic proximity sensor
Date: Fri, 12 Jul 2024 16:33:04 +0200	[thread overview]
Message-ID: <dc509d3a-7e25-49f3-94a2-5a6bb36f062d@web.de> (raw)
In-Reply-To: <20240712113200.2468249-3-wangshuaijie@awinic.com>

Please add a subsystem specification to the message subject.


…
> +++ b/drivers/iio/proximity/aw_sar.c
> @@ -0,0 +1,1850 @@
> +static ssize_t
> +update_reg_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
> +{
> +	if (flag == AW_TRUE) {
> +		mutex_lock(&aw_sar_lock);
> +		aw_sar_soft_reset(p_sar);
> +		aw_sar_update_reg_set_func(p_sar);
> +		mutex_unlock(&aw_sar_lock);
> +	}
> +
> +	return count;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&aw_sar_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc7/source/include/linux/mutex.h#L196

Regards,
Markus

  parent reply	other threads:[~2024-07-12 14:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 11:31 [PATCH V3 0/2] Add support for Awinic SAR sensor wangshuaijie
2024-07-12 11:31 ` [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor wangshuaijie
2024-07-12 11:55   ` Krzysztof Kozlowski
2024-07-13 12:15     ` Jonathan Cameron
2024-07-25 12:47     ` wangshuaijie
2024-07-25 13:53       ` Krzysztof Kozlowski
2024-07-12 12:34   ` Rob Herring (Arm)
2024-07-12 11:32 ` [PATCH V3 2/2] Add support for " wangshuaijie
2024-07-12 12:01   ` Krzysztof Kozlowski
2024-07-25 12:48     ` wangshuaijie
2024-07-12 14:33   ` Markus Elfring [this message]
2024-07-12 22:22   ` kernel test robot
2024-07-13  6:15   ` kernel test robot
2024-07-13  8:50   ` kernel test robot
2024-07-13 10:33   ` kernel test robot
2024-07-13 14:27   ` Jonathan Cameron
2024-07-25 12:47     ` wangshuaijie
2024-07-27 12:22       ` Jonathan Cameron
2024-07-12 11:49 ` [PATCH V3 0/2] Add support for Awinic SAR sensor Waqar Hameed
2024-07-25 12:48   ` wangshuaijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc509d3a-7e25-49f3-94a2-5a6bb36f062d@web.de \
    --to=markus.elfring@web.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kangjiajun@awinic.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liweilei@awinic.com \
    --cc=robh@kernel.org \
    --cc=wangshuaijie@awinic.com \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox