Linux IIO development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>
Subject: Re: [PATCH v2 0/7] Add ADCs support for RZ/T2H and RZ/N2H
Date: Fri, 26 Sep 2025 11:11:46 -0500	[thread overview]
Message-ID: <175890301803.880384.843495445196930858.robh@kernel.org> (raw)
In-Reply-To: <20250925224013.2146983-1-cosmin-gabriel.tanislav.xa@renesas.com>


On Fri, 26 Sep 2025 01:40:02 +0300, Cosmin Tanislav wrote:
> Renesas RZ/T2H (R9A09G077) and RZ/N2H (R9A09G087) SoCs include three
> 12-Bit successive approximation A/D converters.
> 
> RZ/T2H has two ADCs with 4 channels and one with 6.
> RZ/N2H has two ADCs with 4 channels and one with 15.
> 
> Add support for them.
> 
> V2:
>  * pick up Reviewed-by from Geert
>  * dt-bindings: move required after patternProperties
>  * dt-bindings: describe 16 channels, but limit per-SoC to 6 / 15
>  * dt-bindings: use uppercase for clock descriptions
>  * remove max-channels property and find it from parsed channel subnodes
>  * remove start/stop wrappers
>  * stop calibration even on failure
>  * move data reading to rzt2h_adc_read_single() instead of interrupt
>  * handler
> 
> Cosmin Tanislav (7):
>   clk: renesas: r9a09g077: Add ADC modules clock
>   dt-bindings: iio: adc: document RZ/T2H and RZ/N2H ADC
>   iio: adc: add RZ/T2H / RZ/N2H ADC driver
>   arm64: dts: renesas: r9a09g077: Add ADCs support
>   arm64: dts: renesas: r9a09g087: Add ADCs support
>   arm64: dts: renesas: rzt2h/rzn2h-evk: enable ADCs
>   arm64: defconfig: enable RZ/T2H / RZ/N2H ADC driver
> 
>  .../iio/adc/renesas,r9a09g077-adc.yaml        | 160 +++++++++
>  MAINTAINERS                                   |   8 +
>  arch/arm64/boot/dts/renesas/r9a09g077.dtsi    |  69 ++++
>  .../dts/renesas/r9a09g077m44-rzt2h-evk.dts    |  28 ++
>  arch/arm64/boot/dts/renesas/r9a09g087.dtsi    |  69 ++++
>  .../dts/renesas/r9a09g087m44-rzn2h-evk.dts    |  64 ++++
>  .../dts/renesas/rzt2h-n2h-evk-common.dtsi     |  79 +++++
>  arch/arm64/configs/defconfig                  |   1 +
>  drivers/clk/renesas/r9a09g077-cpg.c           |   3 +
>  drivers/iio/adc/Kconfig                       |  10 +
>  drivers/iio/adc/Makefile                      |   1 +
>  drivers/iio/adc/rzt2h_adc.c                   | 306 ++++++++++++++++++
>  12 files changed, 798 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,r9a09g077-adc.yaml
>  create mode 100644 drivers/iio/adc/rzt2h_adc.c
> 
> --
> 2.51.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20250925 (best guess, 2/10 blobs matched)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/renesas/' for 20250925224013.2146983-1-cosmin-gabriel.tanislav.xa@renesas.com:

arch/arm64/boot/dts/renesas/r9a09g077m44-rzt2h-evk.dtb: adc@90014000 (renesas,r9a09g077-adc): 'renesas,max-channels' does not match any of the regexes: '^channel@[0-9a-f]$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iio/adc/renesas,r9a09g077-adc.yaml#
arch/arm64/boot/dts/renesas/r9a09g077m44-rzt2h-evk.dtb: adc@90014400 (renesas,r9a09g077-adc): 'renesas,max-channels' does not match any of the regexes: '^channel@[0-9a-f]$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iio/adc/renesas,r9a09g077-adc.yaml#
arch/arm64/boot/dts/renesas/r9a09g077m44-rzt2h-evk.dtb: adc@80008000 (renesas,r9a09g077-adc): 'renesas,max-channels' does not match any of the regexes: '^channel@[0-9a-f]$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iio/adc/renesas,r9a09g077-adc.yaml#
arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dtb: adc@90014000 (renesas,r9a09g087-adc): 'renesas,max-channels' does not match any of the regexes: '^channel@[0-9a-f]$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iio/adc/renesas,r9a09g077-adc.yaml#
arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dtb: adc@90014400 (renesas,r9a09g087-adc): 'renesas,max-channels' does not match any of the regexes: '^channel@[0-9a-f]$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iio/adc/renesas,r9a09g077-adc.yaml#
arch/arm64/boot/dts/renesas/r9a09g087m44-rzn2h-evk.dtb: adc@80008000 (renesas,r9a09g087-adc): 'renesas,max-channels' does not match any of the regexes: '^channel@[0-9a-f]$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/iio/adc/renesas,r9a09g077-adc.yaml#






      parent reply	other threads:[~2025-09-26 16:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 22:40 [PATCH v2 0/7] Add ADCs support for RZ/T2H and RZ/N2H Cosmin Tanislav
2025-09-25 22:40 ` [PATCH v2 1/7] clk: renesas: r9a09g077: Add ADC modules clock Cosmin Tanislav
2025-09-25 22:40 ` [PATCH v2 2/7] dt-bindings: iio: adc: document RZ/T2H and RZ/N2H ADC Cosmin Tanislav
2025-09-29 11:27   ` Geert Uytterhoeven
2025-09-25 22:40 ` [PATCH v2 3/7] iio: adc: add RZ/T2H / RZ/N2H ADC driver Cosmin Tanislav
2025-09-26 12:10   ` Nuno Sá
2025-09-26 12:41     ` Cosmin-Gabriel Tanislav
2025-09-26 14:41       ` Nuno Sá
2025-09-27 18:06         ` Jonathan Cameron
2025-09-27 18:16   ` Jonathan Cameron
2025-09-25 22:40 ` [PATCH v2 4/7] arm64: dts: renesas: r9a09g077: Add ADCs support Cosmin Tanislav
2025-09-25 22:40 ` [PATCH v2 5/7] arm64: dts: renesas: r9a09g087: " Cosmin Tanislav
2025-09-25 22:40 ` [PATCH v2 6/7] arm64: dts: renesas: rzt2h/rzn2h-evk: enable ADCs Cosmin Tanislav
2025-09-25 22:40 ` [PATCH v2 7/7] arm64: defconfig: enable RZ/T2H / RZ/N2H ADC driver Cosmin Tanislav
2025-09-26 16:11 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175890301803.880384.843495445196930858.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=geert+renesas@glider.be \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox