From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Shreeya Patel <shreeya.patel@collabora.com>,
jic23@kernel.org, lars@metafoo.de, heiko@sntech.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
sebastian.reichel@collabora.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, gustavo.padovan@collabora.com,
serge.broslavsky@collabora.com, Simon Xue <xxm@rock-chips.com>
Subject: Re: [PATCH v2 2/8] iio: adc: rockchip_saradc: Add support for RK3588
Date: Fri, 26 May 2023 10:36:23 +0200 [thread overview]
Message-ID: <17ac612b-4464-4a97-4e4d-5e053b760130@collabora.com> (raw)
In-Reply-To: <20230525212712.255406-3-shreeya.patel@collabora.com>
Il 25/05/23 23:27, Shreeya Patel ha scritto:
> From: Simon Xue <xxm@rock-chips.com>
>
> Add new start and read functions to support rk3588 device.
> Also, add a device compatible string for the same.
>
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
>
> Changes in v2
> - Add a from address.
> - Create separate patches for adding new device support and changes to
> the old device code.
> - Make use of FIELD_PREP.
>
> drivers/iio/adc/rockchip_saradc.c | 69 +++++++++++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 21f9d92a6af4..31637440be83 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
You're missing a header...
#include <linux/bitfield.h>
after adding that, you can get my
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers,
Angelo
next prev parent reply other threads:[~2023-05-26 8:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 21:27 [PATCH v2 0/8] RK3588 ADC support Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 1/8] iio: adc: rockchip_saradc: Add callback functions Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 2/8] iio: adc: rockchip_saradc: Add support for RK3588 Shreeya Patel
2023-05-26 8:36 ` AngeloGioacchino Del Regno [this message]
2023-05-25 21:27 ` [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled Shreeya Patel
2023-05-26 0:42 ` Dmitry Osipenko
2023-05-28 21:22 ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 4/8] iio: adc: rockchip_saradc: Use of_device_get_match_data Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 5/8] iio: adc: rockchip_saradc: Match alignment with open parenthesis Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 6/8] iio: adc: rockchip_saradc: Use dev_err_probe Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 7/8] arm64: dts: rockchip: Add DT node for ADC support in RK3588 Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 8/8] dt-bindings: iio: adc: Add rockchip,rk3588-saradc string Shreeya Patel
2023-05-28 16:46 ` [PATCH v2 0/8] RK3588 ADC support Jonathan Cameron
2023-05-28 21:25 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17ac612b-4464-4a97-4e4d-5e053b760130@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.padovan@collabora.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=serge.broslavsky@collabora.com \
--cc=shreeya.patel@collabora.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox