From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Shreeya Patel <shreeya.patel@collabora.com>,
jic23@kernel.org, lars@metafoo.de, heiko@sntech.de,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
sebastian.reichel@collabora.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, gustavo.padovan@collabora.com,
serge.broslavsky@collabora.com
Subject: Re: [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
Date: Fri, 26 May 2023 03:42:48 +0300 [thread overview]
Message-ID: <a7e0d4f0-a497-8697-e108-5247e11abc41@collabora.com> (raw)
In-Reply-To: <20230525212712.255406-4-shreeya.patel@collabora.com>
On 5/26/23 00:27, Shreeya Patel wrote:
> @@ -600,8 +560,6 @@ static int rockchip_saradc_suspend(struct device *dev)
> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct rockchip_saradc *info = iio_priv(indio_dev);
>
> - clk_disable_unprepare(info->clk);
> - clk_disable_unprepare(info->pclk);
> regulator_disable(info->vref);
Why clocks need to be enabled during suspend?
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-05-26 0:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 21:27 [PATCH v2 0/8] RK3588 ADC support Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 1/8] iio: adc: rockchip_saradc: Add callback functions Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 2/8] iio: adc: rockchip_saradc: Add support for RK3588 Shreeya Patel
2023-05-26 8:36 ` AngeloGioacchino Del Regno
2023-05-25 21:27 ` [PATCH v2 3/8] iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled Shreeya Patel
2023-05-26 0:42 ` Dmitry Osipenko [this message]
2023-05-28 21:22 ` Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 4/8] iio: adc: rockchip_saradc: Use of_device_get_match_data Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 5/8] iio: adc: rockchip_saradc: Match alignment with open parenthesis Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 6/8] iio: adc: rockchip_saradc: Use dev_err_probe Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 7/8] arm64: dts: rockchip: Add DT node for ADC support in RK3588 Shreeya Patel
2023-05-25 21:27 ` [PATCH v2 8/8] dt-bindings: iio: adc: Add rockchip,rk3588-saradc string Shreeya Patel
2023-05-28 16:46 ` [PATCH v2 0/8] RK3588 ADC support Jonathan Cameron
2023-05-28 21:25 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7e0d4f0-a497-8697-e108-5247e11abc41@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.padovan@collabora.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=serge.broslavsky@collabora.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox