Re: [RFC PATCH v2 2/2] iio: light: add support for APDS9999 sensor

[David Lechner <dlechner@baylibre.com>]

On 5/16/26 11:39 AM, Jonathan Cameron wrote:
> On Sat, 16 May 2026 10:28:47 -0500
> David Lechner <dlechner@baylibre.com> wrote:
> 
>> On 5/13/26 3:10 AM, Jose A. Perez de Azpillaga wrote:
>>> Add IIO driver for Broadcom APDS9999 ambient light sensor.
>>>
>>> The APDS9999 is a digital proximity and RGB sensor with ALS
>>> capability. This driver implements the ALS/Lux functionality using
>>> the green channel, which uses optical coating technology to
>>> approximate the human eye spectral response.
>>>
>>> Proximity (PS) and RGB color features are not yet implemented.
>>>   
>>
>>
>>
>>> +enum apds9999_gain {
>>> +	APDS9999_GAIN_1X = 0,
>>> +	APDS9999_GAIN_3X = 1,
>>> +	APDS9999_GAIN_6X = 2,
>>> +	APDS9999_GAIN_9X = 3,
>>> +	APDS9999_GAIN_18X = 4,
>>> +};  
>>
>> Giving the natural values of enum explicitly just seems like noise
>> IMHO. I wasted time looking for an anomaly.
> 
> I tend to ask for this when they are hardware field values to make
> the point the values matter rather than just being an enum.
> I'm not that fussed though.
> 
> Jonathan

In that case, I would just use #define instead of enum.