* [PATCH] ad7780: fix division by zero in ad7780_write_raw()
@ 2024-10-28 14:20 Zicheng Qu
2024-10-31 13:52 ` Zicheng Qu
2024-10-31 21:08 ` Jonathan Cameron
0 siblings, 2 replies; 3+ messages in thread
From: Zicheng Qu @ 2024-10-28 14:20 UTC (permalink / raw)
To: Michael.Hennerich, renatogeh, lars, jic23, giuliano.belinassi,
linux-iio, linux-kernel
Cc: tanghui20, zhangqiao22, judy.chenhui, quzicheng
In the ad7780_write_raw() , val2 can be zero, which might lead to a
division by zero error in DIV_ROUND_CLOSEST(). The ad7780_write_raw()
is based on iio_info's write_raw. While val is explicitly declared that
can be zero (in read mode), val2 is not specified to be non-zero.
Fixes: 9085daa4abcc ("staging: iio: ad7780: add gain & filter gpio support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
---
drivers/iio/adc/ad7780.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7780.c b/drivers/iio/adc/ad7780.c
index e9b0c577c9cc..8ccb74f47030 100644
--- a/drivers/iio/adc/ad7780.c
+++ b/drivers/iio/adc/ad7780.c
@@ -152,7 +152,7 @@ static int ad7780_write_raw(struct iio_dev *indio_dev,
switch (m) {
case IIO_CHAN_INFO_SCALE:
- if (val != 0)
+ if (val != 0 || val2 == 0)
return -EINVAL;
vref = st->int_vref_mv * 1000000LL;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ad7780: fix division by zero in ad7780_write_raw()
2024-10-28 14:20 [PATCH] ad7780: fix division by zero in ad7780_write_raw() Zicheng Qu
@ 2024-10-31 13:52 ` Zicheng Qu
2024-10-31 21:08 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Zicheng Qu @ 2024-10-31 13:52 UTC (permalink / raw)
To: Michael.Hennerich, renatogeh, lars, jic23, giuliano.belinassi,
linux-iio, linux-kernel
Cc: tanghui20, zhangqiao22, judy.chenhui
Gentle ping.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ad7780: fix division by zero in ad7780_write_raw()
2024-10-28 14:20 [PATCH] ad7780: fix division by zero in ad7780_write_raw() Zicheng Qu
2024-10-31 13:52 ` Zicheng Qu
@ 2024-10-31 21:08 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2024-10-31 21:08 UTC (permalink / raw)
To: Zicheng Qu
Cc: Michael.Hennerich, renatogeh, lars, giuliano.belinassi, linux-iio,
linux-kernel, tanghui20, zhangqiao22, judy.chenhui
On Mon, 28 Oct 2024 14:20:27 +0000
Zicheng Qu <quzicheng@huawei.com> wrote:
> In the ad7780_write_raw() , val2 can be zero, which might lead to a
> division by zero error in DIV_ROUND_CLOSEST(). The ad7780_write_raw()
> is based on iio_info's write_raw. While val is explicitly declared that
> can be zero (in read mode), val2 is not specified to be non-zero.
>
> Fixes: 9085daa4abcc ("staging: iio: ad7780: add gain & filter gpio support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
Applied to the fixes-togreg branch of iio.git.
I might end up dragging this in to my queue for the coming merge window
if I don't get time to do another fixes pull request in the next few
days.
Jonathan
> ---
> drivers/iio/adc/ad7780.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7780.c b/drivers/iio/adc/ad7780.c
> index e9b0c577c9cc..8ccb74f47030 100644
> --- a/drivers/iio/adc/ad7780.c
> +++ b/drivers/iio/adc/ad7780.c
> @@ -152,7 +152,7 @@ static int ad7780_write_raw(struct iio_dev *indio_dev,
>
> switch (m) {
> case IIO_CHAN_INFO_SCALE:
> - if (val != 0)
> + if (val != 0 || val2 == 0)
> return -EINVAL;
>
> vref = st->int_vref_mv * 1000000LL;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-31 21:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 14:20 [PATCH] ad7780: fix division by zero in ad7780_write_raw() Zicheng Qu
2024-10-31 13:52 ` Zicheng Qu
2024-10-31 21:08 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox