Linux IIO development
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: michael.hennerich@analog.com
Cc: jic23@cam.ac.uk, linux-iio@vger.kernel.org, drivers@analog.com,
	device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] Staging: IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4
Date: Wed, 9 Feb 2011 15:00:58 -0800	[thread overview]
Message-ID: <20110209230058.GA32064@kroah.com> (raw)
In-Reply-To: <1297253238-1865-1-git-send-email-michael.hennerich@analog.com>

On Wed, Feb 09, 2011 at 01:07:18PM +0100, michael.hennerich@analog.com =
wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>=20
> This patch adds support for the:
> AD7606/AD7606-6/AD7606-4 8/6/4-Channel Data Acquisition
> system (DAS) with 16-Bit, Bipolar, Simultaneous Sampling ADC.
>=20
> Changes since V1:
> IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4: Apply review feedb=
ack
>=20
> Rename sysfs node oversampling to oversampling_ratio.
> Kconfig: Add GPIOLIB dependency.
> Use range in mV to better match HWMON.
> Rename ad7606_check_oversampling.
> Fix various comments and style.
> Reorder is_visible cases.
> Use new gpio_request_one/array and friends.
> Drop check for SPI max_speed_hz.
>=20
> Changes since V2:
> IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4: Apply review feedb=
ack
>=20
> Documentation: specify unit
> Avoid raise condition in ad7606_scan_direct()
> Check return value of bus ops read_block()

This patch fails to build here:

drivers/staging/iio/adc/ad7606_core.c: In function =E2=80=98ad7606_scan=
_direct=E2=80=99:
drivers/staging/iio/adc/ad7606_core.c:47:8: error: =E2=80=98TASK_INTERR=
UPTIBLE=E2=80=99 undeclared (first use in this function)
drivers/staging/iio/adc/ad7606_core.c:47:8: note: each undeclared ident=
ifier is reported only once for each function it appears in
drivers/staging/iio/adc/ad7606_core.c:47:2: error: implicit declaration=
 of function =E2=80=98signal_pending=E2=80=99
drivers/staging/iio/adc/ad7606_core.c:47:2: error: implicit declaration=
 of function =E2=80=98schedule=E2=80=99
drivers/staging/iio/adc/ad7606_core.c: In function =E2=80=98ad7606_inte=
rrupt=E2=80=99:
drivers/staging/iio/adc/ad7606_core.c:400:3: error: =E2=80=98TASK_INTER=
RUPTIBLE=E2=80=99 undeclared (first use in this function)
make[4]: *** [drivers/staging/iio/adc/ad7606_core.o] Error 1


Care to actually test build it next time?  :(

thanks,

greg k-h

  reply	other threads:[~2011-02-09 23:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 12:07 [PATCH] IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4 michael.hennerich
2011-02-09 23:00 ` Greg KH [this message]
2011-02-10  8:32   ` [PATCH] Staging: " Hennerich, Michael
  -- strict thread matches above, loose matches on Subject: below --
2011-02-10  8:28 [PATCH] " michael.hennerich
2011-02-18 21:21 ` [PATCH] Staging: " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110209230058.GA32064@kroah.com \
    --to=greg@kroah.com \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=drivers@analog.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox