From: Greg KH <greg@kroah.com>
To: michael.hennerich@analog.com
Cc: jic23@cam.ac.uk, linux-iio@vger.kernel.org, drivers@analog.com,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] Staging: IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4
Date: Fri, 18 Feb 2011 13:21:26 -0800 [thread overview]
Message-ID: <20110218212126.GA23543@kroah.com> (raw)
In-Reply-To: <1297326484-6618-1-git-send-email-michael.hennerich@analog.com>
On Thu, Feb 10, 2011 at 09:28:04AM +0100, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> This patch adds support for the:
> AD7606/AD7606-6/AD7606-4 8/6/4-Channel Data Acquisition
> system (DAS) with 16-Bit, Bipolar, Simultaneous Sampling ADC.
>
> Changes since V1:
> IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4: Apply review feedback
>
> Rename sysfs node oversampling to oversampling_ratio.
> Kconfig: Add GPIOLIB dependency.
> Use range in mV to better match HWMON.
> Rename ad7606_check_oversampling.
> Fix various comments and style.
> Reorder is_visible cases.
> Use new gpio_request_one/array and friends.
> Drop check for SPI max_speed_hz.
>
> Changes since V2:
> IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4: Apply review feedback
>
> Documentation: specify unit
> Avoid raise condition in ad7606_scan_direct()
> Check return value of bus ops read_block()
>
> Changes since V3:
> IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4: Add missing include file
>
> Add linux/sched.h
It still fails to build here :(
drivers/staging/iio/adc/ad7606_spi.o: In function `init_module':
ad7606_spi.c:(.init.text+0x0): multiple definition of `init_module'
drivers/staging/iio/adc/ad7606_par.o:ad7606_par.c:(.init.text+0x0): first defined here
drivers/staging/iio/adc/ad7606_spi.o: In function `cleanup_module':
ad7606_spi.c:(.exit.text+0x0): multiple definition of `cleanup_module'
drivers/staging/iio/adc/ad7606_par.o:ad7606_par.c:(.exit.text+0x0): first defined here
You need to try your build options better...
thanks,
greg k-h
next prev parent reply other threads:[~2011-02-18 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 8:28 [PATCH] IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4 michael.hennerich
2011-02-18 21:21 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-09 12:07 michael.hennerich
2011-02-09 23:00 ` [PATCH] Staging: " Greg KH
2011-02-10 8:32 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218212126.GA23543@kroah.com \
--to=greg@kroah.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox