From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] staging: (iio) restore macro IIO_ATTR_2
Date: Mon, 25 Jul 2011 11:51:25 -0400 [thread overview]
Message-ID: <20110725115125.199f8f11@v0nbox> (raw)
In-Reply-To: <4E2D53E1.90305@cam.ac.uk>
On Mon, 25 Jul 2011 12:30:41 +0100,
Jonathan Cameron <jic23@cam.ac.uk> wrote:
> On 07/22/11 23:26, Vivien Didelot wrote:
> > For some reason, IIO_ATTR_2 has been deleted by commit
> > 99e5dc45b854b4b661044e807905152911ed3fdb but it is still used by
> > the macro IIO_DEVICE_ATTR_2. This patch restores it.
> > Please ignore it if it shouldn't exist anymore. If so, this would
> > need to remove IIO_DEVICE_ATTR_2 as well. Obviously it seems to be
> > useful as the struct iio_dev_attr has a val2 member.
> Good spot. Do you have a user for the two parameter version? If not
> I'd prefer to just scrap the IIO_DEVICE_ATTR_2 until we actually need
> it. That also means we can scrap val2 from struct iio_dev_attr which
> is a nice little clean up. How about the following?
I'm actually using the second member, as I'm trying to move the TS-5500
ADC driver from HWMON to IIO (you can see the HWMON patch here:
https://lkml.org/lkml/diff/2011/7/19/223/1). It is used in the
ts5500_adc_show_range() function (nr is the equivalent of val2).
But I've found the ad7291.c driver which is 8 channels as well.
It might offer a solution that avoids using this second parameter. Is
it a good driver to refer to in this case?
Regards,
Vivien.
next prev parent reply other threads:[~2011-07-25 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 22:26 [PATCH] staging: (iio) restore macro IIO_ATTR_2 Vivien Didelot
2011-07-25 11:30 ` Jonathan Cameron
2011-07-25 15:51 ` Vivien Didelot [this message]
2011-07-25 16:14 ` Jonathan Cameron
2011-07-25 18:48 ` Vivien Didelot
2011-07-26 11:50 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725115125.199f8f11@v0nbox \
--to=vivien.didelot@savoirfairelinux.com \
--cc=greg@kroah.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox