From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, Greg KH <greg@kroah.com>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>
Subject: Re: [PATCH] staging: (iio) restore macro IIO_ATTR_2
Date: Mon, 25 Jul 2011 14:48:15 -0400 [thread overview]
Message-ID: <20110725144815.4d654942@v0nbox> (raw)
In-Reply-To: <4E2D9673.3040602@cam.ac.uk>
On Mon, 25 Jul 2011 17:14:43 +0100,
Jonathan Cameron <jic23@cam.ac.uk> wrote :
> > But I've found the ad7291.c driver which is 8 channels as well.
> > It might offer a solution that avoids using this second parameter.
> > Is it a good driver to refer to in this case?
> >
> > Regards,
> > Vivien.
> No. Look at any of max1363, ad799x, ad7887 and indeed pretty much any
> of the others that have undergone chan_spec conversion.
>
> Usual principal with drivers is find one that has a lot of active
> development to copy.
>
> Michael is the ad7291 on your cleanup list? It's on another planet
> abi wise...
>
> Sorry Vivien if you wasted any time copying stuff from there.
> We decided just the other day to start maintaining broken out TODO
> files for the drivers. Sorry we didn't have those in place already or
> it might have saved you time.
>
> Jonathan
That's ok, I understand that this new subsystem is moving fast.
By the way, that's why I've proposed an HWMON version of the TS-5500
ADC driver in the new set of patches for the TS-5500 support
(https://lkml.org/lkml/2011/7/19/220, which has no comment yet). As it
is integrated as part of this platform and functional at the moment,
those patches could be applied initially, then a future patch could
move the ADC driver from HWMON to IIO.
This discussion could continue on the TS-5500 patches request if you
prefer. What do you think?
Regards,
Vivien.
next prev parent reply other threads:[~2011-07-25 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 22:26 [PATCH] staging: (iio) restore macro IIO_ATTR_2 Vivien Didelot
2011-07-25 11:30 ` Jonathan Cameron
2011-07-25 15:51 ` Vivien Didelot
2011-07-25 16:14 ` Jonathan Cameron
2011-07-25 18:48 ` Vivien Didelot [this message]
2011-07-26 11:50 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725144815.4d654942@v0nbox \
--to=vivien.didelot@savoirfairelinux.com \
--cc=Michael.Hennerich@analog.com \
--cc=greg@kroah.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox