* [PATCH 0/3] tsl2583 checkpatch fixes
@ 2014-04-09 23:28 Michael Welling
2014-04-09 23:28 ` [PATCH 1/3] Removes unwanted space before semicolon Michael Welling
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michael Welling @ 2014-04-09 23:28 UTC (permalink / raw)
To: linux-iio, jic23, gregkh; +Cc: Michael Welling
Removes all checkpatch warnings.
Michael Welling (3):
Removes unwanted space before semicolon
Remove quoted string split across lines warnings
Switch from msleep to usleep range per timers-howto.txt
drivers/staging/iio/light/tsl2583.c | 38 ++++++++++++++++++-----------------
1 file changed, 20 insertions(+), 18 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] Removes unwanted space before semicolon
2014-04-09 23:28 [PATCH 0/3] tsl2583 checkpatch fixes Michael Welling
@ 2014-04-09 23:28 ` Michael Welling
2014-04-10 1:47 ` Greg KH
2014-04-09 23:28 ` [PATCH 2/3] Remove quoted string split across lines warnings Michael Welling
2014-04-09 23:28 ` [PATCH 3/3] Switch from msleep to usleep range per timers-howto.txt Michael Welling
2 siblings, 1 reply; 6+ messages in thread
From: Michael Welling @ 2014-04-09 23:28 UTC (permalink / raw)
To: linux-iio, jic23, gregkh; +Cc: Michael Welling
---
drivers/staging/iio/light/tsl2583.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index 0a60def..77c7f65 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -211,7 +211,7 @@ static int taos_get_lux(struct iio_dev *indio_dev)
if (chip->taos_chip_status != TSL258X_CHIP_WORKING) {
/* device is not enabled */
dev_err(&chip->client->dev, "taos_get_lux device is not enabled\n");
- ret = -EBUSY ;
+ ret = -EBUSY;
goto out_unlock;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] Remove quoted string split across lines warnings
2014-04-09 23:28 [PATCH 0/3] tsl2583 checkpatch fixes Michael Welling
2014-04-09 23:28 ` [PATCH 1/3] Removes unwanted space before semicolon Michael Welling
@ 2014-04-09 23:28 ` Michael Welling
2014-04-09 23:28 ` [PATCH 3/3] Switch from msleep to usleep range per timers-howto.txt Michael Welling
2 siblings, 0 replies; 6+ messages in thread
From: Michael Welling @ 2014-04-09 23:28 UTC (permalink / raw)
To: linux-iio, jic23, gregkh; +Cc: Michael Welling
---
drivers/staging/iio/light/tsl2583.c | 34 ++++++++++++++++++----------------
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index 77c7f65..f015fb4 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -165,8 +165,9 @@ taos_i2c_read(struct i2c_client *client, u8 reg, u8 *val, unsigned int len)
/* select register to write */
ret = i2c_smbus_write_byte(client, (TSL258X_CMD_REG | reg));
if (ret < 0) {
- dev_err(&client->dev, "taos_i2c_read failed to write"
- " register %x\n", reg);
+ dev_err(&client->dev,
+ "taos_i2c_read failed to write register %x\n",
+ reg);
return ret;
}
/* read the data */
@@ -231,8 +232,9 @@ static int taos_get_lux(struct iio_dev *indio_dev)
int reg = TSL258X_CMD_REG | (TSL258X_ALS_CHAN0LO + i);
ret = taos_i2c_read(chip->client, reg, &buf[i], 1);
if (ret < 0) {
- dev_err(&chip->client->dev, "taos_get_lux failed to read"
- " register %x\n", reg);
+ dev_err(&chip->client->dev,
+ "taos_get_lux failed to read register %x\n",
+ reg);
goto out_unlock;
}
}
@@ -809,9 +811,7 @@ static int taos_probe(struct i2c_client *clientp,
if (!i2c_check_functionality(clientp->adapter,
I2C_FUNC_SMBUS_BYTE_DATA)) {
- dev_err(&clientp->dev,
- "taos_probe() - i2c smbus byte data "
- "functions unsupported\n");
+ dev_err(&clientp->dev, "taos_probe() - i2c smbus byte data func unsupported\n");
return -EOPNOTSUPP;
}
@@ -830,30 +830,32 @@ static int taos_probe(struct i2c_client *clientp,
ret = i2c_smbus_write_byte(clientp,
(TSL258X_CMD_REG | (TSL258X_CNTRL + i)));
if (ret < 0) {
- dev_err(&clientp->dev, "i2c_smbus_write_bytes() to cmd "
- "reg failed in taos_probe(), err = %d\n", ret);
+ dev_err(&clientp->dev,
+ "i2c_smbus_write_byte to cmd reg failed in taos_probe(), err = %d\n",
+ ret);
return ret;
}
ret = i2c_smbus_read_byte(clientp);
if (ret < 0) {
- dev_err(&clientp->dev, "i2c_smbus_read_byte from "
- "reg failed in taos_probe(), err = %d\n", ret);
-
+ dev_err(&clientp->dev,
+ "i2c_smbus_read_byte from reg failed in taos_probe(), err = %d\n",
+ ret);
return ret;
}
buf[i] = ret;
}
if (!taos_tsl258x_device(buf)) {
- dev_info(&clientp->dev, "i2c device found but does not match "
- "expected id in taos_probe()\n");
+ dev_info(&clientp->dev,
+ "i2c device found but does not match expected id in taos_probe()\n");
return -EINVAL;
}
ret = i2c_smbus_write_byte(clientp, (TSL258X_CMD_REG | TSL258X_CNTRL));
if (ret < 0) {
- dev_err(&clientp->dev, "i2c_smbus_write_byte() to cmd reg "
- "failed in taos_probe(), err = %d\n", ret);
+ dev_err(&clientp->dev,
+ "i2c_smbus_write_byte() to cmd reg failed in taos_probe(), err = %d\n",
+ ret);
return ret;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] Switch from msleep to usleep range per timers-howto.txt
2014-04-09 23:28 [PATCH 0/3] tsl2583 checkpatch fixes Michael Welling
2014-04-09 23:28 ` [PATCH 1/3] Removes unwanted space before semicolon Michael Welling
2014-04-09 23:28 ` [PATCH 2/3] Remove quoted string split across lines warnings Michael Welling
@ 2014-04-09 23:28 ` Michael Welling
2 siblings, 0 replies; 6+ messages in thread
From: Michael Welling @ 2014-04-09 23:28 UTC (permalink / raw)
To: linux-iio, jic23, gregkh; +Cc: Michael Welling
---
drivers/staging/iio/light/tsl2583.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index f015fb4..fa96498 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -451,7 +451,7 @@ static int taos_chip_on(struct iio_dev *indio_dev)
}
}
- msleep(3);
+ usleep_range(3000, 3500);
/* NOW enable the ADC
* initialize the desired mode of operation */
utmp = TSL258X_CNTL_PWR_ON | TSL258X_CNTL_ADC_ENBL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Removes unwanted space before semicolon
2014-04-09 23:28 ` [PATCH 1/3] Removes unwanted space before semicolon Michael Welling
@ 2014-04-10 1:47 ` Greg KH
2014-04-10 2:30 ` Michael Welling
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-04-10 1:47 UTC (permalink / raw)
To: Michael Welling; +Cc: linux-iio, jic23
On Wed, Apr 09, 2014 at 06:28:47PM -0500, Michael Welling wrote:
> ---
> drivers/staging/iio/light/tsl2583.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The subject: needs to be better (put Staging: iio:) in the beginning.
Also, you forgot a signed-off-by line all of these.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Removes unwanted space before semicolon
2014-04-10 1:47 ` Greg KH
@ 2014-04-10 2:30 ` Michael Welling
0 siblings, 0 replies; 6+ messages in thread
From: Michael Welling @ 2014-04-10 2:30 UTC (permalink / raw)
To: Greg KH; +Cc: linux-iio, jic23
On Wed, Apr 09, 2014 at 06:47:58PM -0700, Greg KH wrote:
> On Wed, Apr 09, 2014 at 06:28:47PM -0500, Michael Welling wrote:
> > ---
> > drivers/staging/iio/light/tsl2583.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> The subject: needs to be better (put Staging: iio:) in the beginning.
>
Sorry, updated patch series send.
> Also, you forgot a signed-off-by line all of these.
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-10 2:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 23:28 [PATCH 0/3] tsl2583 checkpatch fixes Michael Welling
2014-04-09 23:28 ` [PATCH 1/3] Removes unwanted space before semicolon Michael Welling
2014-04-10 1:47 ` Greg KH
2014-04-10 2:30 ` Michael Welling
2014-04-09 23:28 ` [PATCH 2/3] Remove quoted string split across lines warnings Michael Welling
2014-04-09 23:28 ` [PATCH 3/3] Switch from msleep to usleep range per timers-howto.txt Michael Welling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox