From: Sergei Zviagintsev <sergei@s15v.net>
To: Adriana Reus <adriana.reus@intel.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio: light: Add support for TXC PA12 als and proximity sensor
Date: Mon, 29 Jun 2015 21:09:15 +0300 [thread overview]
Message-ID: <20150629180915.GA17917@localhost.localdomain> (raw)
In-Reply-To: <1435596828-10436-1-git-send-email-adriana.reus@intel.com>
Hi,
On Mon, Jun 29, 2015 at 07:53:48PM +0300, Adriana Reus wrote:
[...]
> +struct {
> + u8 reg;
> + u8 val;
> +} regvals[] = {
> + {PA12203001_REG_CFG0, PA12203001_REG_CFG0_DEFAULT},
> + {PA12203001_REG_CFG1, PA12203001_REG_CFG1_DEFAULT},
> + {PA12203001_REG_CFG2, PA12203001_REG_CFG2_DEFAULT},
> + {PA12203001_REG_CFG3, PA12203001_REG_CFG3_DEFAULT},
> + {PA12203001_REG_PSET, PA12203001_PSCAN},
> +};
It seems like `static' keyword is missed here.
next prev parent reply other threads:[~2015-06-29 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 16:53 [PATCH v2] iio: light: Add support for TXC PA12 als and proximity sensor Adriana Reus
2015-06-29 18:09 ` Sergei Zviagintsev [this message]
2015-07-05 14:18 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629180915.GA17917@localhost.localdomain \
--to=sergei@s15v.net \
--cc=adriana.reus@intel.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox