Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Icenowy Zheng]

CjIwMTflubQ05pyINuaXpSAwMzowNOS6jiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPuWG
memBk++8mgo+Cj4gT24gVHVlLCBBcHIgNCwgMjAxNyBhdCAxMDowMiBBTSwgSWNlbm93eSBaaGVu
ZyA8aWNlbm93eUBhb3NjLmlvPiB3cm90ZTogCj4gPiAKPiA+IAo+ID4g5ZyoIDIwMTflubQwNOac
iDA05pelIDIyOjQ3LCBSb2IgSGVycmluZyDlhpnpgZM6IAo+ID4+IAo+ID4+IE9uIFN1biwgQXBy
IDAyLCAyMDE3IGF0IDA5OjMzOjAxUE0gKzA4MDAsIEljZW5vd3kgWmhlbmcgd3JvdGU6IAo+ID4+
PiAKPiA+Pj4gQWxsd2lubmVyIEgzIGZlYXR1cmVzIGEgdGhlcm1hbCBzZW5zb3IgbGlrZSB0aGUg
b25lIGluIEEzMywgYnV0IGhhcyBpdHMgCj4gPj4+IHJlZ2lzdGVyIHJlLWFycmFuZ2VkLCB0aGUg
Y2xvY2sgZGl2aWRlciBtb3ZlZCB0byBDQ1UgKG9yaWdpbmFsbHkgdGhlIAo+ID4+PiBjbG9jayBk
aXZpZGVyIGlzIGluIEFEQykgYW5kIGFkZGVkIGEgcGFpciBvZiBidXMgY2xvY2sgYW5kIHJlc2V0
LiAKPiA+Pj4gCj4gPj4+IFVwZGF0ZSB0aGUgYmluZGluZyBkb2N1bWVudCB0byBjb3ZlciBIMy4g
Cj4gPj4+IAo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBJY2Vub3d5IFpoZW5nIDxpY2Vub3d5QGFvc2Mu
aW8+IAo+ID4+PiAtLS0gCj4gPj4+wqAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL3N1bjRp
LWdwYWRjLnR4dMKgwqDCoMKgwqDCoMKgIHwgMjMgCj4gPj4+ICsrKysrKysrKysrKysrKysrKysr
LS0gCj4gPj4+wqAgMSBmaWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z
KC0pIAo+ID4+PiAKPiA+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i
aW5kaW5ncy9tZmQvc3VuNGktZ3BhZGMudHh0IAo+ID4+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNl
dHJlZS9iaW5kaW5ncy9tZmQvc3VuNGktZ3BhZGMudHh0IAo+ID4+PiBpbmRleCBiYWRmZjM2MTFh
OTguLjc3NTMxMzNjYTBmZiAxMDA2NDQgCj4gPj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNl
dHJlZS9iaW5kaW5ncy9tZmQvc3VuNGktZ3BhZGMudHh0IAo+ID4+PiArKysgYi9Eb2N1bWVudGF0
aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL3N1bjRpLWdwYWRjLnR4dCAKPiA+Pj4gQEAgLTQs
MTIgKzQsMjAgQEAgVGhlIEFsbHdpbm5lciBTb0NzIGFsbCBoYXZlIGFuIEFEQyB0aGF0IGNhbiBh
bHNvIGFjdCBhcyAKPiA+Pj4gYSB0aGVybWFsIHNlbnNvciAKPiA+Pj7CoCBhbmQgc29tZXRpbWVz
IGFzIGEgdG91Y2hzY3JlZW4gY29udHJvbGxlci4gCj4gPj4+IAo+ID4+PsKgIFJlcXVpcmVkIHBy
b3BlcnRpZXM6IAo+ID4+PiAtwqAgLSBjb21wYXRpYmxlOiAiYWxsd2lubmVyLHN1bjhpLWEzMy10
aHMiLCAKPiA+Pj4gK8KgIC0gY29tcGF0aWJsZTogbXVzdCBjb250YWluIG9uZSBvZiB0aGUgZm9s
bG93aW5nIGNvbXBhdGlibGVzOiAKPiA+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
LSAiYWxsd2lubmVyLHN1bjhpLWEzMy10aHMiIAo+ID4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCAtICJhbGx3aW5uZXIsc3VuOGktaDMtdGhzIiAKPiA+Pj7CoMKgwqAgLSByZWc6IG1t
aW8gYWRkcmVzcyByYW5nZSBvZiB0aGUgY2hpcCwgCj4gPj4+wqDCoMKgIC0gI3RoZXJtYWwtc2Vu
c29yLWNlbGxzOiBzaGFsbCBiZSAwLCAKPiA+Pj7CoMKgwqAgLSAjaW8tY2hhbm5lbC1jZWxsczog
c2hhbGwgYmUgMCwgCj4gPj4+IAo+ID4+PiAtRXhhbXBsZTogCj4gPj4+ICtSZXF1aXJlZCBwcm9w
ZXJ0aWVzIGZvciB0aGUgZm9sbG93aW5nIGNvbXBhdGlibGVzOiAKPiA+Pj4gK8KgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgLSAiYWxsd2lubmVyLHN1bjhpLWgzLXRocyIgCj4gPj4+ICvCoCAt
IGNsb2NrczogdGhlIGJ1cyBjbG9jayBhbmQgdGhlIGlucHV0IGNsb2NrIG9mIHRoZSBBREMsIAo+
ID4+PiArwqAgLSBjbG9jay1uYW1lczogc2hvdWxkIGJlICJidXMiIGFuZCAidGhzIiwgCj4gPj4+
ICvCoCAtIHJlc2V0czogdGhlIGJ1cyByZXNldCBvZiB0aGUgQURDLCAKPiA+Pj4gKyAKPiA+Pj4g
K0V4YW1wbGUgZm9yIEEzMzogCj4gPj4+wqDCoMKgwqDCoMKgwqDCoCB0aHM6IHRoc0AwMWMyNTAw
MCB7IAo+ID4+PsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbXBhdGlibGUgPSAi
YWxsd2lubmVyLHN1bjhpLWEzMy10aHMiOyAKPiA+Pj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCByZWcgPSA8MHgwMWMyNTAwMCAweDEwMD47IAo+ID4+PiBAQCAtMTcsNiArMjUsMTcg
QEAgRXhhbXBsZTogCj4gPj4+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgI2lvLWNo
YW5uZWwtY2VsbHMgPSA8MD47IAo+ID4+PsKgwqDCoMKgwqDCoMKgwqAgfTsgCj4gPj4+IAo+ID4+
PiArRXhhbXBsZSBmb3IgSDM6IAo+ID4+PiArwqDCoMKgwqDCoMKgIHRoczogdGhzQDAxYzI1MDAw
IHsgCj4gPj4gCj4gPj4gCj4gPj4gYWRjQC4uLiAKPiA+IAo+ID4gCj4gPiBJdCdzIGEgdGhlcm1h
bCBzZW5zb3IsIHNvIEkgdGhpbmsgY2FsbCBpdCBUSFMgaXMgbW9yZSBhcHByb3ByaWF0ZSAKPiA+
IGhlcmUuIEl0J3MgaW1wbGVtZW50ZWQgYXMgYW4gQURDIGRyaXZlciBqdXN0IGJlY2F1c2UgdGhl
IGludGVybmFsIAo+ID4gY29kZSByZXVzaW5nIG9mIExpbnV4LiBGcm9tIGRldmljZSB0cmVlIGJp
bmRpbmcgdmlldyBJIGNob29zZSB0byAKPiA+IGNhbGwgaXQgdGhzLiAKPgo+IFRoZXJlJ3MgbnVt
ZXJvdXMgb2NjdXJyZW5jZXMgaW4gdGhpcyBmaWxlIGFuZCB0aGUgZmlsZW5hbWUgdGhhdCBjYWxs
IGl0IGFuIEFEQy4gCj4KPiBGdXJ0aGVybW9yZSwgbm9kZSBuYW1lcyBhcmUgc3VwcG9zZWQgdG8g
YmUgZ2VuZXJpYywgbm90IHBhcnQgIydzIG9yIAo+IHdoYXRldmVyIHlvdSBkZWNpZGUgdG8gbWFr
ZSB1cC4gU28gcGljayBmcm9tIGFkYyBvciB0ZW1wZXJhdHVyZS1zZW5zb3IgCj4gYXMgdGhvc2Ug
YXJlIHRoZSBzdGFuZGFyZCBuYW1lcyAuIAoKT0suIEkgd2lsbCBtYWtlIGl0IDoKdGhzOiB0ZW1w
ZXJhdHVyZS1zZW5zb3JAMWMyNTAwMAoKKENhbGxpbmcgaXQgdGVtcGVyYXR1cmUgc2Vuc29yIGlz
IGFjY29yZGluZyB0byB0aGUgZGF0YXNoZWV0IG5hbWUpCgo+Cj4gUm9iIAo=

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Lee Jones]

On Thu, 06 Apr 2017, Icenowy Zheng wrote:
> 2017年4月6日 03:04于 Rob Herring <robh@kernel.org>写道：
> > On Tue, Apr 4, 2017 at 10:02 AM, Icenowy Zheng <icenowy@aosc.io> wrote: 

> > > 在 2017年04月04日 22:47, Rob Herring 写道: 

> OK. I will make it :
> ths: temperature-sensor@1c25000

Can you fix your broken email client please?  You need to set it up to
reply to mails to they stay threaded.  Your mailer is currently
sending all of your replies as their own, independent messages.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[RFC PATCH v2 0/4] IIO-based thermal sensor driver for Allwinner H3 SoC

[Icenowy Zheng]

Allwiner H3 SoC has a thermal sensor, which is a large refactored version of
the old Allwinner "GPADC" (although it have already only thermal part left
in A33).

This patch tried to add support for the sensor in H3 based on the A33
thermal sensor patchset by Quentin Schulz at [1].

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-March/495505.html

Icenowy Zheng (4):
  dt-bindings: update the Allwinner GPADC device tree binding for H3
  iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to
    contain A23
  iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor
  ARM: sun8i: h3: add support for the thermal sensor in H3

 .../devicetree/bindings/mfd/sun4i-gpadc.txt        |  23 ++-
 arch/arm/boot/dts/sun8i-h3.dtsi                    |  26 +++
 drivers/iio/adc/sun4i-gpadc-iio.c                  | 215 +++++++++++++++++----
 include/linux/mfd/sun4i-gpadc.h                    |  36 +++-
 4 files changed, 254 insertions(+), 46 deletions(-)

-- 
2.12.2

[RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Icenowy Zheng]

Allwinner H3 features a thermal sensor like the one in A33, but has its
register re-arranged, the clock divider moved to CCU (originally the
clock divider is in ADC) and added a pair of bus clock and reset.

Update the binding document to cover H3.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 ++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
index badff3611a98..7753133ca0ff 100644
--- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
+++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
@@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor
 and sometimes as a touchscreen controller.
 
 Required properties:
-  - compatible: "allwinner,sun8i-a33-ths",
+  - compatible: must contain one of the following compatibles:
+		- "allwinner,sun8i-a33-ths"
+		- "allwinner,sun8i-h3-ths"
   - reg: mmio address range of the chip,
   - #thermal-sensor-cells: shall be 0,
   - #io-channel-cells: shall be 0,
 
-Example:
+Required properties for the following compatibles:
+		- "allwinner,sun8i-h3-ths"
+  - clocks: the bus clock and the input clock of the ADC,
+  - clock-names: should be "bus" and "ths",
+  - resets: the bus reset of the ADC,
+
+Example for A33:
 	ths: ths@01c25000 {
 		compatible = "allwinner,sun8i-a33-ths";
 		reg = <0x01c25000 0x100>;
@@ -17,6 +25,17 @@ Example:
 		#io-channel-cells = <0>;
 	};
 
+Example for H3:
+	ths: ths@01c25000 {
+		compatible = "allwinner,sun8i-h3-ths";
+		reg = <0x01c25000 0x100>;
+		clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;
+		clock-names = "bus", "ths";
+		resets = <&ccu RST_BUS_THS>;
+		#thermal-sensor-cells = <0>;
+		#io-channel-cells = <0>;
+	};
+
 sun4i, sun5i and sun6i SoCs are also supported via the older binding:
 
 sun4i resistive touchscreen controller
-- 
2.12.2

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1689 bytes --]

On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote:
> Allwinner H3 features a thermal sensor like the one in A33, but has its
> register re-arranged, the clock divider moved to CCU (originally the
> clock divider is in ADC) and added a pair of bus clock and reset.
> 
> Update the binding document to cover H3.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 ++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> index badff3611a98..7753133ca0ff 100644
> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor
>  and sometimes as a touchscreen controller.
>  
>  Required properties:
> -  - compatible: "allwinner,sun8i-a33-ths",
> +  - compatible: must contain one of the following compatibles:
> +		- "allwinner,sun8i-a33-ths"
> +		- "allwinner,sun8i-h3-ths"
>    - reg: mmio address range of the chip,
>    - #thermal-sensor-cells: shall be 0,
>    - #io-channel-cells: shall be 0,
>  
> -Example:
> +Required properties for the following compatibles:
> +		- "allwinner,sun8i-h3-ths"
> +  - clocks: the bus clock and the input clock of the ADC,
> +  - clock-names: should be "bus" and "ths",

I guess mod instead of ths would be more consistent.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Icenowy Zheng]

=E5=9C=A8 2017=E5=B9=B404=E6=9C=8803=E6=97=A5 17:15, Maxime Ripard =E5=86=
=99=E9=81=93:
> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote:
>> Allwinner H3 features a thermal sensor like the one in A33, but has it=
s
>> register re-arranged, the clock divider moved to CCU (originally the
>> clock divider is in ADC) and added a pair of bus clock and reset.
>>
>> Update the binding document to cover H3.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> ---
>>  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 +++++++++++++=
+++++++--
>>  1 file changed, 21 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/D=
ocumentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>> index badff3611a98..7753133ca0ff 100644
>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act=
 as a thermal sensor
>>  and sometimes as a touchscreen controller.
>>
>>  Required properties:
>> -  - compatible: "allwinner,sun8i-a33-ths",
>> +  - compatible: must contain one of the following compatibles:
>> +		- "allwinner,sun8i-a33-ths"
>> +		- "allwinner,sun8i-h3-ths"
>>    - reg: mmio address range of the chip,
>>    - #thermal-sensor-cells: shall be 0,
>>    - #io-channel-cells: shall be 0,
>>
>> -Example:
>> +Required properties for the following compatibles:
>> +		- "allwinner,sun8i-h3-ths"
>> +  - clocks: the bus clock and the input clock of the ADC,
>> +  - clock-names: should be "bus" and "ths",
>
> I guess mod instead of ths would be more consistent.

In fact I will prefer "sample" here if not "ths", as it's used
for the sampling, not like other mod clocks, which controls
all the IP block's logic.

>
> Maxime
>

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 2302 bytes --]

On Mon, Apr 03, 2017 at 05:31:11PM +0800, Icenowy Zheng wrote:
> 
> 
> 在 2017年04月03日 17:15, Maxime Ripard 写道:
> > On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote:
> > > Allwinner H3 features a thermal sensor like the one in A33, but has its
> > > register re-arranged, the clock divider moved to CCU (originally the
> > > clock divider is in ADC) and added a pair of bus clock and reset.
> > > 
> > > Update the binding document to cover H3.
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > ---
> > >  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 ++++++++++++++++++++--
> > >  1 file changed, 21 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> > > index badff3611a98..7753133ca0ff 100644
> > > --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> > > +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> > > @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor
> > >  and sometimes as a touchscreen controller.
> > > 
> > >  Required properties:
> > > -  - compatible: "allwinner,sun8i-a33-ths",
> > > +  - compatible: must contain one of the following compatibles:
> > > +		- "allwinner,sun8i-a33-ths"
> > > +		- "allwinner,sun8i-h3-ths"
> > >    - reg: mmio address range of the chip,
> > >    - #thermal-sensor-cells: shall be 0,
> > >    - #io-channel-cells: shall be 0,
> > > 
> > > -Example:
> > > +Required properties for the following compatibles:
> > > +		- "allwinner,sun8i-h3-ths"
> > > +  - clocks: the bus clock and the input clock of the ADC,
> > > +  - clock-names: should be "bus" and "ths",
> > 
> > I guess mod instead of ths would be more consistent.
> 
> In fact I will prefer "sample" here if not "ths", as it's used
> for the sampling, not like other mod clocks, which controls
> all the IP block's logic.

All the other mod clocks control some sort of sampling. The audio mod
clocks will be used to sample data in capture, same thing for NAND,
MMC, SPI, etc.

Please remain consistent.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Rob Herring]

On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote:
> Allwinner H3 features a thermal sensor like the one in A33, but has its
> register re-arranged, the clock divider moved to CCU (originally the
> clock divider is in ADC) and added a pair of bus clock and reset.
> 
> Update the binding document to cover H3.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 ++++++++++++++++++++--
>  1 file changed, 21 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> index badff3611a98..7753133ca0ff 100644
> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor
>  and sometimes as a touchscreen controller.
>  
>  Required properties:
> -  - compatible: "allwinner,sun8i-a33-ths",
> +  - compatible: must contain one of the following compatibles:
> +		- "allwinner,sun8i-a33-ths"
> +		- "allwinner,sun8i-h3-ths"
>    - reg: mmio address range of the chip,
>    - #thermal-sensor-cells: shall be 0,
>    - #io-channel-cells: shall be 0,
>  
> -Example:
> +Required properties for the following compatibles:
> +		- "allwinner,sun8i-h3-ths"
> +  - clocks: the bus clock and the input clock of the ADC,
> +  - clock-names: should be "bus" and "ths",
> +  - resets: the bus reset of the ADC,
> +
> +Example for A33:
>  	ths: ths@01c25000 {
>  		compatible = "allwinner,sun8i-a33-ths";
>  		reg = <0x01c25000 0x100>;
> @@ -17,6 +25,17 @@ Example:
>  		#io-channel-cells = <0>;
>  	};
>  
> +Example for H3:
> +	ths: ths@01c25000 {

adc@...

And drop the leading 0.

> +		compatible = "allwinner,sun8i-h3-ths";
> +		reg = <0x01c25000 0x100>;
> +		clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;
> +		clock-names = "bus", "ths";
> +		resets = <&ccu RST_BUS_THS>;
> +		#thermal-sensor-cells = <0>;
> +		#io-channel-cells = <0>;
> +	};
> +
>  sun4i, sun5i and sun6i SoCs are also supported via the older binding:
>  
>  sun4i resistive touchscreen controller
> -- 
> 2.12.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Icenowy Zheng]

在 2017年04月04日 22:47, Rob Herring 写道:
> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote:
>> Allwinner H3 features a thermal sensor like the one in A33, but has its
>> register re-arranged, the clock divider moved to CCU (originally the
>> clock divider is in ADC) and added a pair of bus clock and reset.
>>
>> Update the binding document to cover H3.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> ---
>>  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 ++++++++++++++++++++--
>>  1 file changed, 21 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>> index badff3611a98..7753133ca0ff 100644
>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor
>>  and sometimes as a touchscreen controller.
>>
>>  Required properties:
>> -  - compatible: "allwinner,sun8i-a33-ths",
>> +  - compatible: must contain one of the following compatibles:
>> +		- "allwinner,sun8i-a33-ths"
>> +		- "allwinner,sun8i-h3-ths"
>>    - reg: mmio address range of the chip,
>>    - #thermal-sensor-cells: shall be 0,
>>    - #io-channel-cells: shall be 0,
>>
>> -Example:
>> +Required properties for the following compatibles:
>> +		- "allwinner,sun8i-h3-ths"
>> +  - clocks: the bus clock and the input clock of the ADC,
>> +  - clock-names: should be "bus" and "ths",
>> +  - resets: the bus reset of the ADC,
>> +
>> +Example for A33:
>>  	ths: ths@01c25000 {
>>  		compatible = "allwinner,sun8i-a33-ths";
>>  		reg = <0x01c25000 0x100>;
>> @@ -17,6 +25,17 @@ Example:
>>  		#io-channel-cells = <0>;
>>  	};
>>
>> +Example for H3:
>> +	ths: ths@01c25000 {
>
> adc@...

It's a thermal sensor, so I think call it THS is more appropriate
here. It's implemented as an ADC driver just because the internal
code reusing of Linux. From device tree binding view I choose to
call it ths.

>
> And drop the leading 0.

OK.

>
>> +		compatible = "allwinner,sun8i-h3-ths";
>> +		reg = <0x01c25000 0x100>;
>> +		clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;
>> +		clock-names = "bus", "ths";
>> +		resets = <&ccu RST_BUS_THS>;
>> +		#thermal-sensor-cells = <0>;
>> +		#io-channel-cells = <0>;
>> +	};
>> +
>>  sun4i, sun5i and sun6i SoCs are also supported via the older binding:
>>
>>  sun4i resistive touchscreen controller
>> --
>> 2.12.2
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

[Rob Herring]

On Tue, Apr 4, 2017 at 10:02 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
> 在 2017年04月04日 22:47, Rob Herring 写道:
>>
>> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote:
>>>
>>> Allwinner H3 features a thermal sensor like the one in A33, but has its
>>> register re-arranged, the clock divider moved to CCU (originally the
>>> clock divider is in ADC) and added a pair of bus clock and reset.
>>>
>>> Update the binding document to cover H3.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>>  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23
>>> ++++++++++++++++++++--
>>>  1 file changed, 21 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>>> b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>>> index badff3611a98..7753133ca0ff 100644
>>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
>>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as
>>> a thermal sensor
>>>  and sometimes as a touchscreen controller.
>>>
>>>  Required properties:
>>> -  - compatible: "allwinner,sun8i-a33-ths",
>>> +  - compatible: must contain one of the following compatibles:
>>> +               - "allwinner,sun8i-a33-ths"
>>> +               - "allwinner,sun8i-h3-ths"
>>>    - reg: mmio address range of the chip,
>>>    - #thermal-sensor-cells: shall be 0,
>>>    - #io-channel-cells: shall be 0,
>>>
>>> -Example:
>>> +Required properties for the following compatibles:
>>> +               - "allwinner,sun8i-h3-ths"
>>> +  - clocks: the bus clock and the input clock of the ADC,
>>> +  - clock-names: should be "bus" and "ths",
>>> +  - resets: the bus reset of the ADC,
>>> +
>>> +Example for A33:
>>>         ths: ths@01c25000 {
>>>                 compatible = "allwinner,sun8i-a33-ths";
>>>                 reg = <0x01c25000 0x100>;
>>> @@ -17,6 +25,17 @@ Example:
>>>                 #io-channel-cells = <0>;
>>>         };
>>>
>>> +Example for H3:
>>> +       ths: ths@01c25000 {
>>
>>
>> adc@...
>
>
> It's a thermal sensor, so I think call it THS is more appropriate
> here. It's implemented as an ADC driver just because the internal
> code reusing of Linux. From device tree binding view I choose to
> call it ths.

There's numerous occurrences in this file and the filename that call it an ADC.

Furthermore, node names are supposed to be generic, not part #'s or
whatever you decide to make up. So pick from adc or temperature-sensor
as those are the standard names .

Rob