From: Chen Guanqiao <chen.chenchacha@foxmail.com>
To: pmeerw@pmeerw.net, jic23@kernel.org
Cc: Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
Chen Guanqiao <chen.chenchacha@foxmail.com>
Subject: [PATCH v4 0/1] iio:meter:ade7759: use 4-digit octal permissions
Date: Sun, 9 Apr 2017 23:20:59 +0800 [thread overview]
Message-ID: <20170409152100.30778-1-chen.chenchacha@foxmail.com> (raw)
In-Reply-To: <20170409043027.13930-3-chen.chenchacha@foxmail.com>
This patch that fixes coding style problem.
Please note:
the checkpatch.pl will be reports error:
>ERROR: Use 4 digit octal (0777) not decimal permissions
>#320: FILE: drivers/staging/iio/meter/ade7759.c:320:
>+static IIO_DEV_ATTR_CH_OFF(1,
>+ 0644,
>+ ade7759_read_8bit,
>+ ade7759_write_8bit,
>+ ADE7759_CH1OS);
>ERROR: Use 4 digit octal (0777) not decimal permissions
>#325: FILE: drivers/staging/iio/meter/ade7759.c:325:
>+static IIO_DEV_ATTR_CH_OFF(2,
>+ 0644,
>+ ade7759_read_8bit,
>+ ade7759_write_8bit,
>+ ADE7759_CH2OS);
Because the script checks the first parameter as permissions in function like
"IIO_DEV_ATTR_[A-Z_]+" and the IIO_DEV_ATTR_CH_OFF permissions parameter is
second.
So, I think this is a problem of checkpatch.pl.
version 4:
- fixes the IIO_DEV_ATTR_CH_OFF
version 3:
- update the title and patch scription
- divide the patch into two parts
version 2:
- corrected spelling error
Chen Guanqiao (1):
iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO,
S_IWUSR)
drivers/staging/iio/meter/ade7759.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.11.0
next prev parent reply other threads:[~2017-04-09 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 2:13 [PATCH v2] iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO, S_IWUSR, S_IXUGO) Chen Guanqiao
2017-04-08 17:01 ` Jonathan Cameron
2017-04-09 4:30 ` [PATCH v3 0/2] iio:meter:ade7759: use 4-digit octal permissions Chen Guanqiao
2017-04-09 4:30 ` [PATCH v3 1/2] iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO, S_IWUSR, S_IXUGO) Chen Guanqiao
2017-04-09 8:18 ` Jonathan Cameron
2017-04-09 4:30 ` [PATCH v3 2/2] iio:meter:ade7759: realign the rest with opening bracket Chen Guanqiao
2017-04-09 8:26 ` Jonathan Cameron
2017-04-09 15:20 ` Chen Guanqiao [this message]
2017-04-09 15:21 ` [PATCH v4 1/1] iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO, S_IWUSR) Chen Guanqiao
2017-04-14 14:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409152100.30778-1-chen.chenchacha@foxmail.com \
--to=chen.chenchacha@foxmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox