From: Jonathan Cameron <jic23@kernel.org>
To: Chen Guanqiao <chen.chenchacha@foxmail.com>, pmeerw@pmeerw.net
Cc: Michael.Hennerich@analog.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO, S_IWUSR, S_IXUGO)
Date: Sat, 8 Apr 2017 18:01:47 +0100 [thread overview]
Message-ID: <5b992963-ecd4-56b5-33a6-ccad29b99180@kernel.org> (raw)
In-Reply-To: <260495ce-b068-a5ce-6ec3-a90fdd7e2510@foxmail.com>
On 04/04/17 03:13, Chen Guanqiao wrote:
> Removing use of deprecated macros(S_IRUGO, S_IWUSR, S_IXUGO), and replace
> with 4 digit octal.
>
> Signed-off-by: Chen Guanqiao <chen.chenchacha@foxmail.com>
Not keen on the reformatting... However, there is an obvious way to clean
it up further whilst you are here.
Jonathan
> ---
> drivers/staging/iio/meter/ade7759.c | 26 ++++++++++++++------------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c
> index 0b65f1847510..dbd106f28cb7 100644
> --- a/drivers/staging/iio/meter/ade7759.c
> +++ b/drivers/staging/iio/meter/ade7759.c
> @@ -279,49 +279,51 @@ static int ade7759_reset(struct device *dev)
> }
>
> static IIO_DEV_ATTR_AENERGY(ade7759_read_40bit, ADE7759_AENERGY);
> -static IIO_DEV_ATTR_CFDEN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CFDEN(0644,
> ade7759_read_16bit,
> ade7759_write_16bit,
> ADE7759_CFDEN);
> -static IIO_DEV_ATTR_CFNUM(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CFNUM(0644,
> ade7759_read_8bit,
> ade7759_write_8bit,
> ADE7759_CFNUM);
> static IIO_DEV_ATTR_CHKSUM(ade7759_read_8bit, ADE7759_CHKSUM);
> -static IIO_DEV_ATTR_PHCAL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_PHCAL(0644,
> ade7759_read_16bit,
> ade7759_write_16bit,
> ADE7759_PHCAL);
> -static IIO_DEV_ATTR_APOS(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_APOS(0644,
> ade7759_read_16bit,
> ade7759_write_16bit,
> ADE7759_APOS);
> -static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_SAGCYC(0644,
> ade7759_read_8bit,
> ade7759_write_8bit,
> ADE7759_SAGCYC);
> -static IIO_DEV_ATTR_SAGLVL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_SAGLVL(0644,
> ade7759_read_8bit,
> ade7759_write_8bit,
> ADE7759_SAGLVL);
> -static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_LINECYC(0644,
> ade7759_read_8bit,
> ade7759_write_8bit,
> ADE7759_LINECYC);
> static IIO_DEV_ATTR_LENERGY(ade7759_read_40bit, ADE7759_LENERGY);
> -static IIO_DEV_ATTR_PGA_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_PGA_GAIN(0644,
> ade7759_read_8bit,
> ade7759_write_8bit,
> ADE7759_GAIN);
> -static IIO_DEV_ATTR_ACTIVE_POWER_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_ACTIVE_POWER_GAIN(0644,
> ade7759_read_16bit,
> ade7759_write_16bit,
> ADE7759_APGAIN);
> -static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CH_OFF(
> + 1, 0644,
> ade7759_read_8bit,
> ade7759_write_8bit,
> ADE7759_CH1OS);
> -static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CH_OFF(
> + 2, 0644,
static IIO_DEV_ATTR_CH_OFF(2, 0644,
and realign the rest with opening bracket. Make sure you update the
title and patch description to reflect this.
> ade7759_read_8bit,
> ade7759_write_8bit,
> ADE7759_CH2OS);
> @@ -458,7 +460,7 @@ static IIO_DEV_ATTR_TEMP_RAW(ade7759_read_8bit);
> static IIO_CONST_ATTR(in_temp_offset, "70 C");
> static IIO_CONST_ATTR(in_temp_scale, "1 C");
>
> -static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_SAMP_FREQ(0644,
> ade7759_read_frequency,
> ade7759_write_frequency);
>
>
next prev parent reply other threads:[~2017-04-08 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 2:13 [PATCH v2] iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO, S_IWUSR, S_IXUGO) Chen Guanqiao
2017-04-08 17:01 ` Jonathan Cameron [this message]
2017-04-09 4:30 ` [PATCH v3 0/2] iio:meter:ade7759: use 4-digit octal permissions Chen Guanqiao
2017-04-09 4:30 ` [PATCH v3 1/2] iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO, S_IWUSR, S_IXUGO) Chen Guanqiao
2017-04-09 8:18 ` Jonathan Cameron
2017-04-09 4:30 ` [PATCH v3 2/2] iio:meter:ade7759: realign the rest with opening bracket Chen Guanqiao
2017-04-09 8:26 ` Jonathan Cameron
2017-04-09 15:20 ` [PATCH v4 0/1] iio:meter:ade7759: use 4-digit octal permissions Chen Guanqiao
2017-04-09 15:21 ` [PATCH v4 1/1] iio:meter:ade7759: Removing use of deprecated macros (S_IRUGO, S_IWUSR) Chen Guanqiao
2017-04-14 14:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b992963-ecd4-56b5-33a6-ccad29b99180@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=chen.chenchacha@foxmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox