From: Jonathan Cameron <jic23@kernel.org>
To: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
singhalsimran0@gmail.com, linux-iio@vger.kernel.org,
Fugang Duan <B38611@freescale.com>
Subject: Re: [PATCH] iio: adc: vf610_adc: Fix VALT selection value for REFSEL bits
Date: Thu, 6 Jul 2017 19:41:01 +0100 [thread overview]
Message-ID: <20170706194101.428c49a1@kernel.org> (raw)
In-Reply-To: <1499332001-8486-1-git-send-email-stefan-gabriel.mirea@nxp.com>
On Thu, 6 Jul 2017 10:06:41 +0100
Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com> wrote:
> In order to select the alternate voltage reference pair (VALTH/VALTL), the
> right value for the REFSEL field in the ADCx_CFG register is "01", leading
> to 0x800 as register mask. See section 8.2.6.4 in the reference manual[1].
>
> [1] http://www.nxp.com/docs/en/reference-manual/VFXXXRM.pdf
>
> Fixes: a775427632fd ("iio:adc:imx: add Freescale Vybrid vf610 adc driver")
> Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com>
Looks good.
Applied to the fixes to greg branch of iio.git.
Cc'd Fugang as the original author.
Btw if you know the author is no longer available, adding a note below the
--- saves on me trying to get hold of them!
Thanks,
Jonathan
> ---
> drivers/iio/adc/vf610_adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index 01fc76f7d660..c168e0db329a 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -77,7 +77,7 @@
> #define VF610_ADC_ADSTS_MASK 0x300
> #define VF610_ADC_ADLPC_EN 0x80
> #define VF610_ADC_ADHSC_EN 0x400
> -#define VF610_ADC_REFSEL_VALT 0x100
> +#define VF610_ADC_REFSEL_VALT 0x800
> #define VF610_ADC_REFSEL_VBG 0x1000
> #define VF610_ADC_ADTRG_HARD 0x2000
> #define VF610_ADC_AVGS_8 0x4000
next prev parent reply other threads:[~2017-07-06 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 9:06 [PATCH] iio: adc: vf610_adc: Fix VALT selection value for REFSEL bits Stefan-Gabriel Mirea
2017-07-06 18:41 ` Jonathan Cameron [this message]
2017-07-07 8:54 ` Stefan-gabriel Mirea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706194101.428c49a1@kernel.org \
--to=jic23@kernel.org \
--cc=B38611@freescale.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=singhalsimran0@gmail.com \
--cc=stefan-gabriel.mirea@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox