[PATCH] iio: adc: vf610_adc: Fix VALT selection value for REFSEL bits

[PATCH] iio: adc: vf610_adc: Fix VALT selection value for REFSEL bits

[Stefan-Gabriel Mirea]

In order to select the alternate voltage reference pair (VALTH/VALTL), the
right value for the REFSEL field in the ADCx_CFG register is "01", leading
to 0x800 as register mask. See section 8.2.6.4 in the reference manual[1].

[1] http://www.nxp.com/docs/en/reference-manual/VFXXXRM.pdf

Fixes: a775427632fd ("iio:adc:imx: add Freescale Vybrid vf610 adc driver")
Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com>
---
 drivers/iio/adc/vf610_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index 01fc76f7d660..c168e0db329a 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -77,7 +77,7 @@
 #define VF610_ADC_ADSTS_MASK		0x300
 #define VF610_ADC_ADLPC_EN		0x80
 #define VF610_ADC_ADHSC_EN		0x400
-#define VF610_ADC_REFSEL_VALT		0x100
+#define VF610_ADC_REFSEL_VALT		0x800
 #define VF610_ADC_REFSEL_VBG		0x1000
 #define VF610_ADC_ADTRG_HARD		0x2000
 #define VF610_ADC_AVGS_8		0x4000
-- 
1.9.1

Re: [PATCH] iio: adc: vf610_adc: Fix VALT selection value for REFSEL bits

[Jonathan Cameron]

On Thu,  6 Jul 2017 10:06:41 +0100
Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com> wrote:

> In order to select the alternate voltage reference pair (VALTH/VALTL), the
> right value for the REFSEL field in the ADCx_CFG register is "01", leading
> to 0x800 as register mask. See section 8.2.6.4 in the reference manual[1].
> 
> [1] http://www.nxp.com/docs/en/reference-manual/VFXXXRM.pdf
> 
> Fixes: a775427632fd ("iio:adc:imx: add Freescale Vybrid vf610 adc driver")
> Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com>
Looks good.

Applied to the fixes to greg branch of iio.git.  

Cc'd Fugang as the original author.

Btw if you know the author is no longer available, adding a note below the
  --- saves on me trying to get hold of them!

Thanks,

Jonathan
> ---
>  drivers/iio/adc/vf610_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index 01fc76f7d660..c168e0db329a 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -77,7 +77,7 @@
>  #define VF610_ADC_ADSTS_MASK		0x300
>  #define VF610_ADC_ADLPC_EN		0x80
>  #define VF610_ADC_ADHSC_EN		0x400
> -#define VF610_ADC_REFSEL_VALT		0x100
> +#define VF610_ADC_REFSEL_VALT		0x800
>  #define VF610_ADC_REFSEL_VBG		0x1000
>  #define VF610_ADC_ADTRG_HARD		0x2000
>  #define VF610_ADC_AVGS_8		0x4000

RE: [PATCH] iio: adc: vf610_adc: Fix VALT selection value for REFSEL bits

[Stefan-gabriel Mirea]

Jonathan Cameron <jic23@kernel.org> writes:
> Looks good.
>=20
> Applied to the fixes to greg branch of iio.git.

Thank you.

> Cc'd Fugang as the original author.
>=20
> Btw if you know the author is no longer available, adding a note below th=
e
>   --- saves on me trying to get hold of them!

I only took maintainers from the get_maintainer.pl output. Now I Cc'd Andy
Duan on his new address as well.

Stefan