public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Chengguang Xu <cgxu519@gmx.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: remove redundant unlikely annotation
Date: Wed, 20 Feb 2019 10:47:53 +0000	[thread overview]
Message-ID: <20190220104753.62ae8823@archlinux> (raw)
In-Reply-To: <20190218075326.24672-1-cgxu519@gmx.com>

On Mon, 18 Feb 2019 15:53:26 +0800
Chengguang Xu <cgxu519@gmx.com> wrote:

> unlikely has already included in IS_ERR(),
> so just remove redundant unlikely annotation.
> 
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to poke at it.

From an IIO point of view, we are almost certainly closed
for the coming merge window, so this will be next time
around.

Thanks,

Jonathan
> ---
>  drivers/iio/trigger/iio-trig-loop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> index 94a90e0a3fdb..9258d3cf149b 100644
> --- a/drivers/iio/trigger/iio-trig-loop.c
> +++ b/drivers/iio/trigger/iio-trig-loop.c
> @@ -60,7 +60,7 @@ static int iio_loop_trigger_set_state(struct iio_trigger *trig, bool state)
>  	if (state) {
>  		loop_trig->task = kthread_run(iio_loop_thread,
>  					      trig, trig->name);
> -		if (unlikely(IS_ERR(loop_trig->task))) {
> +		if (IS_ERR(loop_trig->task)) {
>  			dev_err(&trig->dev,
>  				"failed to create trigger loop thread\n");
>  			return PTR_ERR(loop_trig->task);


      reply	other threads:[~2019-02-20 10:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  7:53 [PATCH] iio: remove redundant unlikely annotation Chengguang Xu
2019-02-20 10:47 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190220104753.62ae8823@archlinux \
    --to=jic23@kernel.org \
    --cc=cgxu519@gmx.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox