* [PATCH] iio: remove redundant unlikely annotation
@ 2019-02-18 7:53 Chengguang Xu
2019-02-20 10:47 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2019-02-18 7:53 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw; +Cc: linux-iio, Chengguang Xu
unlikely has already included in IS_ERR(),
so just remove redundant unlikely annotation.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
drivers/iio/trigger/iio-trig-loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
index 94a90e0a3fdb..9258d3cf149b 100644
--- a/drivers/iio/trigger/iio-trig-loop.c
+++ b/drivers/iio/trigger/iio-trig-loop.c
@@ -60,7 +60,7 @@ static int iio_loop_trigger_set_state(struct iio_trigger *trig, bool state)
if (state) {
loop_trig->task = kthread_run(iio_loop_thread,
trig, trig->name);
- if (unlikely(IS_ERR(loop_trig->task))) {
+ if (IS_ERR(loop_trig->task)) {
dev_err(&trig->dev,
"failed to create trigger loop thread\n");
return PTR_ERR(loop_trig->task);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: remove redundant unlikely annotation
2019-02-18 7:53 [PATCH] iio: remove redundant unlikely annotation Chengguang Xu
@ 2019-02-20 10:47 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-02-20 10:47 UTC (permalink / raw)
To: Chengguang Xu; +Cc: knaack.h, lars, pmeerw, linux-iio
On Mon, 18 Feb 2019 15:53:26 +0800
Chengguang Xu <cgxu519@gmx.com> wrote:
> unlikely has already included in IS_ERR(),
> so just remove redundant unlikely annotation.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to poke at it.
From an IIO point of view, we are almost certainly closed
for the coming merge window, so this will be next time
around.
Thanks,
Jonathan
> ---
> drivers/iio/trigger/iio-trig-loop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> index 94a90e0a3fdb..9258d3cf149b 100644
> --- a/drivers/iio/trigger/iio-trig-loop.c
> +++ b/drivers/iio/trigger/iio-trig-loop.c
> @@ -60,7 +60,7 @@ static int iio_loop_trigger_set_state(struct iio_trigger *trig, bool state)
> if (state) {
> loop_trig->task = kthread_run(iio_loop_thread,
> trig, trig->name);
> - if (unlikely(IS_ERR(loop_trig->task))) {
> + if (IS_ERR(loop_trig->task)) {
> dev_err(&trig->dev,
> "failed to create trigger loop thread\n");
> return PTR_ERR(loop_trig->task);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-20 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-18 7:53 [PATCH] iio: remove redundant unlikely annotation Chengguang Xu
2019-02-20 10:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox