[PATCH] iio: pressure: bmp280: BMP280 calibration to entropy

[PATCH] iio: pressure: bmp280: BMP280 calibration to entropy

[Linus Walleij]

The BMP280/BME280 calibration data should also go into the
entropy pool, like we do for BMP180.

This just adds the temperature and pressure calibration, the
humidity calibration seems like too much annoying calls to
add.

Cc: Tomasz Duszynski <tduszyns@gmail.com>
Cc: Stefan Tatschner <stefan.tatschner@gmail.com>
Cc: Andreas Klinger <ak@it-klinger.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/iio/pressure/bmp280-core.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index fe87d27779d9..3329d740c86c 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -164,6 +164,9 @@ static int bmp280_read_calib(struct bmp280_data *data,
 		return ret;
 	}
 
+	/* Toss the temperature calibration data into the entropy pool */
+	add_device_randomness(t_buf, sizeof(t_buf));
+
 	calib->T1 = le16_to_cpu(t_buf[T1]);
 	calib->T2 = le16_to_cpu(t_buf[T2]);
 	calib->T3 = le16_to_cpu(t_buf[T3]);
@@ -177,6 +180,9 @@ static int bmp280_read_calib(struct bmp280_data *data,
 		return ret;
 	}
 
+	/* Toss the pressure calibration data into the entropy pool */
+	add_device_randomness(p_buf, sizeof(p_buf));
+
 	calib->P1 = le16_to_cpu(p_buf[P1]);
 	calib->P2 = le16_to_cpu(p_buf[P2]);
 	calib->P3 = le16_to_cpu(p_buf[P3]);
-- 
2.20.1

Re: [PATCH] iio: pressure: bmp280: BMP280 calibration to entropy

[Jonathan Cameron]

On Tue, 12 Mar 2019 09:40:18 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> The BMP280/BME280 calibration data should also go into the
> entropy pool, like we do for BMP180.
> 
> This just adds the temperature and pressure calibration, the
> humidity calibration seems like too much annoying calls to
> add.
> 
> Cc: Tomasz Duszynski <tduszyns@gmail.com>
> Cc: Stefan Tatschner <stefan.tatschner@gmail.com>
> Cc: Andreas Klinger <ak@it-klinger.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
I'm going to assume you checked these are actually factory set
to values that vary.

Anyhow, applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to play with them.

Thanks,

Jonathan

> ---
>  drivers/iio/pressure/bmp280-core.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index fe87d27779d9..3329d740c86c 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -164,6 +164,9 @@ static int bmp280_read_calib(struct bmp280_data *data,
>  		return ret;
>  	}
>  
> +	/* Toss the temperature calibration data into the entropy pool */
> +	add_device_randomness(t_buf, sizeof(t_buf));
> +
>  	calib->T1 = le16_to_cpu(t_buf[T1]);
>  	calib->T2 = le16_to_cpu(t_buf[T2]);
>  	calib->T3 = le16_to_cpu(t_buf[T3]);
> @@ -177,6 +180,9 @@ static int bmp280_read_calib(struct bmp280_data *data,
>  		return ret;
>  	}
>  
> +	/* Toss the pressure calibration data into the entropy pool */
> +	add_device_randomness(p_buf, sizeof(p_buf));
> +
>  	calib->P1 = le16_to_cpu(p_buf[P1]);
>  	calib->P2 = le16_to_cpu(p_buf[P2]);
>  	calib->P3 = le16_to_cpu(p_buf[P3]);