[PATCH] drivers: iio: accel: Switch hardcoded function name with a reference to __func__ making the code more maintainable

[PATCH] drivers: iio: accel: Switch hardcoded function name with a reference to __func__ making the code more maintainable

[Mohan Kumar]

It fixes the following checkpatch.pl warning:

WARNING: Prefer using '"%s...", __func__' to using function's name, in a
string

Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
---
 drivers/iio/accel/bmc150-accel-core.c | 2 +-
 drivers/iio/accel/kxcjk-1013.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
index b4e2d9b..44d7c49 100644
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -394,7 +394,7 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
 
 	if (ret < 0) {
 		dev_err(dev,
-			"Failed: bmc150_accel_set_power_state for %d\n", on);
+			"Failed: %s for %d\n", __func__, on);
 		if (on)
 			pm_runtime_put_noidle(dev);
 
diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index a5c9d3d..cbcf3ee0 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -451,7 +451,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on)
 	}
 	if (ret < 0) {
 		dev_err(&data->client->dev,
-			"Failed: kxcjk1013_set_power_state for %d\n", on);
+			"Failed: %s for %d\n", __func__, on);
 		if (on)
 			pm_runtime_put_noidle(&data->client->dev);
 		return ret;
-- 
2.7.4

Re: [PATCH] drivers: iio: accel: Switch hardcoded function name with a reference to __func__ making the code more maintainable

[Jonathan Cameron]

On Fri, 19 Apr 2019 11:36:51 +0300
Mohan Kumar <mohankumar718@gmail.com> wrote:

> It fixes the following checkpatch.pl warning:
> 
> WARNING: Prefer using '"%s...", __func__' to using function's name, in a
> string
> 
> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
Patch is good, but please check other patches for the area
git log --oneline -- drivers/iio to get the standard formatting
for descriptions.  The patch title is also a bit to long.

I've edited that and applied the patch to the togreg branch
of iio.git and pushed out as testing for the autobuilders to
play with it.

Thanks

Jonathan

> ---
>  drivers/iio/accel/bmc150-accel-core.c | 2 +-
>  drivers/iio/accel/kxcjk-1013.c        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
> index b4e2d9b..44d7c49 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -394,7 +394,7 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
>  
>  	if (ret < 0) {
>  		dev_err(dev,
> -			"Failed: bmc150_accel_set_power_state for %d\n", on);
> +			"Failed: %s for %d\n", __func__, on);
>  		if (on)
>  			pm_runtime_put_noidle(dev);
>  
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index a5c9d3d..cbcf3ee0 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -451,7 +451,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on)
>  	}
>  	if (ret < 0) {
>  		dev_err(&data->client->dev,
> -			"Failed: kxcjk1013_set_power_state for %d\n", on);
> +			"Failed: %s for %d\n", __func__, on);
>  		if (on)
>  			pm_runtime_put_noidle(&data->client->dev);
>  		return ret;