* [PATCH] iio: ad_sigma_delta: return directly in ad_sd_buffer_postenable()
@ 2019-05-30 7:25 Alexandru Ardelean
2019-06-08 14:10 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Ardelean @ 2019-05-30 7:25 UTC (permalink / raw)
To: linux-iio; +Cc: Alexandru Ardelean
There is nothing being done after the `err_predisable` label, so just
remove it.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/iio/adc/ad_sigma_delta.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index a4310600a853..ec0e38566ece 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -358,7 +358,7 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)
ret = ad_sigma_delta_set_channel(sigma_delta,
indio_dev->channels[channel].address);
if (ret)
- goto err_predisable;
+ return ret;
spi_bus_lock(sigma_delta->spi->master);
sigma_delta->bus_locked = true;
@@ -375,7 +375,6 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)
err_unlock:
spi_bus_unlock(sigma_delta->spi->master);
-err_predisable:
return ret;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: ad_sigma_delta: return directly in ad_sd_buffer_postenable()
2019-05-30 7:25 [PATCH] iio: ad_sigma_delta: return directly in ad_sd_buffer_postenable() Alexandru Ardelean
@ 2019-06-08 14:10 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-06-08 14:10 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-iio
On Thu, 30 May 2019 10:25:41 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> There is nothing being done after the `err_predisable` label, so just
> remove it.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad_sigma_delta.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index a4310600a853..ec0e38566ece 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -358,7 +358,7 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)
> ret = ad_sigma_delta_set_channel(sigma_delta,
> indio_dev->channels[channel].address);
> if (ret)
> - goto err_predisable;
> + return ret;
>
> spi_bus_lock(sigma_delta->spi->master);
> sigma_delta->bus_locked = true;
> @@ -375,7 +375,6 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)
>
> err_unlock:
> spi_bus_unlock(sigma_delta->spi->master);
> -err_predisable:
>
> return ret;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-08 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-30 7:25 [PATCH] iio: ad_sigma_delta: return directly in ad_sd_buffer_postenable() Alexandru Ardelean
2019-06-08 14:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox