* [PATCH] iio: proximity: pulsedlight v2: Tidy up an endian issue
@ 2019-10-13 10:26 jic23
2019-10-13 17:58 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 10:26 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Matt Ranostay
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Sparse identified the following
CHECK drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
This cleans up by adding a local variable to hold the value whilst
it is __be16 before applying endian converstion into eventual destination.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Matt Ranostay <matt.ranostay@konsulko.com>
---
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
index 47af54f14756..5b369645ef49 100644
--- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
+++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
@@ -136,12 +136,13 @@ static inline int lidar_write_power(struct lidar_data *data, int val)
static int lidar_read_measurement(struct lidar_data *data, u16 *reg)
{
+ __be16 value;
int ret = data->xfer(data, LIDAR_REG_DATA_HBYTE |
(data->i2c_enabled ? LIDAR_REG_DATA_WORD_READ : 0),
- (u8 *) reg, 2);
+ (u8 *) &value, 2);
if (!ret)
- *reg = be16_to_cpu(*reg);
+ *reg = be16_to_cpu(value);
return ret;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: proximity: pulsedlight v2: Tidy up an endian issue
2019-10-13 10:26 [PATCH] iio: proximity: pulsedlight v2: Tidy up an endian issue jic23
@ 2019-10-13 17:58 ` Matt Ranostay
2019-10-18 18:58 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2019-10-13 17:58 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: open list:IIO SUBSYSTEM AND DRIVERS, Jonathan Cameron
On Sun, Oct 13, 2019 at 1:28 PM <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Sparse identified the following
> CHECK drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
> drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
> drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
> drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
>
> This cleans up by adding a local variable to hold the value whilst
> it is __be16 before applying endian converstion into eventual destination.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Matt Ranostay <matt.ranostay@konsulko.com>
Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
> ---
> drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> index 47af54f14756..5b369645ef49 100644
> --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> @@ -136,12 +136,13 @@ static inline int lidar_write_power(struct lidar_data *data, int val)
>
> static int lidar_read_measurement(struct lidar_data *data, u16 *reg)
> {
> + __be16 value;
> int ret = data->xfer(data, LIDAR_REG_DATA_HBYTE |
> (data->i2c_enabled ? LIDAR_REG_DATA_WORD_READ : 0),
> - (u8 *) reg, 2);
> + (u8 *) &value, 2);
>
> if (!ret)
> - *reg = be16_to_cpu(*reg);
> + *reg = be16_to_cpu(value);
>
> return ret;
> }
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: proximity: pulsedlight v2: Tidy up an endian issue
2019-10-13 17:58 ` Matt Ranostay
@ 2019-10-18 18:58 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-10-18 18:58 UTC (permalink / raw)
To: Matt Ranostay; +Cc: open list:IIO SUBSYSTEM AND DRIVERS, Jonathan Cameron
On Sun, 13 Oct 2019 20:58:26 +0300
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> On Sun, Oct 13, 2019 at 1:28 PM <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Sparse identified the following
> > CHECK drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
> > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
> > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
> > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
> >
> > This cleans up by adding a local variable to hold the value whilst
> > it is __be16 before applying endian converstion into eventual destination.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Matt Ranostay <matt.ranostay@konsulko.com>
>
> Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
Applied. Thanks,
Jonathan
>
> > ---
> > drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> > index 47af54f14756..5b369645ef49 100644
> > --- a/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> > +++ b/drivers/iio/proximity/pulsedlight-lidar-lite-v2.c
> > @@ -136,12 +136,13 @@ static inline int lidar_write_power(struct lidar_data *data, int val)
> >
> > static int lidar_read_measurement(struct lidar_data *data, u16 *reg)
> > {
> > + __be16 value;
> > int ret = data->xfer(data, LIDAR_REG_DATA_HBYTE |
> > (data->i2c_enabled ? LIDAR_REG_DATA_WORD_READ : 0),
> > - (u8 *) reg, 2);
> > + (u8 *) &value, 2);
> >
> > if (!ret)
> > - *reg = be16_to_cpu(*reg);
> > + *reg = be16_to_cpu(value);
> >
> > return ret;
> > }
> > --
> > 2.23.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-18 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-13 10:26 [PATCH] iio: proximity: pulsedlight v2: Tidy up an endian issue jic23
2019-10-13 17:58 ` Matt Ranostay
2019-10-18 18:58 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox