* [PATCH] iio:adc:mcp320x: Tidy up endian types in type cast.
@ 2019-10-13 9:05 jic23
2019-10-13 10:52 ` Lukas Wunner
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 9:05 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Lukas Wunner
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes the sparse warning:
drivers/iio/adc/mcp320x.c:167:41: warning: incorrect type in argument 1 (different base types)
drivers/iio/adc/mcp320x.c:167:41: expected restricted __be32 const [usertype] *p
drivers/iio/adc/mcp320x.c:167:41: got unsigned int [usertype] *<noident>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Lukas Wunner <lukas@wunner.de>
---
drivers/iio/adc/mcp320x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
index 38bf10085696..465c7625a55a 100644
--- a/drivers/iio/adc/mcp320x.c
+++ b/drivers/iio/adc/mcp320x.c
@@ -164,7 +164,7 @@ static int mcp320x_adc_conversion(struct mcp320x *adc, u8 channel,
case mcp3550_60:
case mcp3551:
case mcp3553: {
- u32 raw = be32_to_cpup((u32 *)adc->rx_buf);
+ u32 raw = be32_to_cpup((__be32 *)adc->rx_buf);
if (!(adc->spi->mode & SPI_CPOL))
raw <<= 1; /* strip Data Ready bit in SPI mode 0,0 */
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio:adc:mcp320x: Tidy up endian types in type cast.
2019-10-13 9:05 [PATCH] iio:adc:mcp320x: Tidy up endian types in type cast jic23
@ 2019-10-13 10:52 ` Lukas Wunner
2019-10-17 21:48 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Lukas Wunner @ 2019-10-13 10:52 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Jonathan Cameron
On Sun, Oct 13, 2019 at 10:05:42AM +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Fixes the sparse warning:
> drivers/iio/adc/mcp320x.c:167:41: warning: incorrect type in argument 1 (different base types)
> drivers/iio/adc/mcp320x.c:167:41: expected restricted __be32 const [usertype] *p
> drivers/iio/adc/mcp320x.c:167:41: got unsigned int [usertype] *<noident>
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Thanks,
Lukas
> ---
> drivers/iio/adc/mcp320x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index 38bf10085696..465c7625a55a 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -164,7 +164,7 @@ static int mcp320x_adc_conversion(struct mcp320x *adc, u8 channel,
> case mcp3550_60:
> case mcp3551:
> case mcp3553: {
> - u32 raw = be32_to_cpup((u32 *)adc->rx_buf);
> + u32 raw = be32_to_cpup((__be32 *)adc->rx_buf);
>
> if (!(adc->spi->mode & SPI_CPOL))
> raw <<= 1; /* strip Data Ready bit in SPI mode 0,0 */
> --
> 2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio:adc:mcp320x: Tidy up endian types in type cast.
2019-10-13 10:52 ` Lukas Wunner
@ 2019-10-17 21:48 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-10-17 21:48 UTC (permalink / raw)
To: Lukas Wunner; +Cc: linux-iio, Jonathan Cameron
On Sun, 13 Oct 2019 12:52:01 +0200
Lukas Wunner <lukas@wunner.de> wrote:
> On Sun, Oct 13, 2019 at 10:05:42AM +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Fixes the sparse warning:
> > drivers/iio/adc/mcp320x.c:167:41: warning: incorrect type in argument 1 (different base types)
> > drivers/iio/adc/mcp320x.c:167:41: expected restricted __be32 const [usertype] *p
> > drivers/iio/adc/mcp320x.c:167:41: got unsigned int [usertype] *<noident>
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
Applied.
Thanks,
Jonathan
>
> Thanks,
>
> Lukas
>
>
> > ---
> > drivers/iio/adc/mcp320x.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> > index 38bf10085696..465c7625a55a 100644
> > --- a/drivers/iio/adc/mcp320x.c
> > +++ b/drivers/iio/adc/mcp320x.c
> > @@ -164,7 +164,7 @@ static int mcp320x_adc_conversion(struct mcp320x *adc, u8 channel,
> > case mcp3550_60:
> > case mcp3551:
> > case mcp3553: {
> > - u32 raw = be32_to_cpup((u32 *)adc->rx_buf);
> > + u32 raw = be32_to_cpup((__be32 *)adc->rx_buf);
> >
> > if (!(adc->spi->mode & SPI_CPOL))
> > raw <<= 1; /* strip Data Ready bit in SPI mode 0,0 */
> > --
> > 2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-17 21:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-13 9:05 [PATCH] iio:adc:mcp320x: Tidy up endian types in type cast jic23
2019-10-13 10:52 ` Lukas Wunner
2019-10-17 21:48 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox