* [PATCH] iio: adc: xilinix-xadc: use devm_platform_ioremap_resource
@ 2019-10-13 16:48 jic23
2019-10-14 19:56 ` Sven Van Asbroeck
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 16:48 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Manish Narani, Sven Van Asbroeck
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reduces local boilerplate.
Suggested by coccinelle.
CHECK drivers/iio/adc/xilinx-xadc-core.c
drivers/iio/adc/xilinx-xadc-core.c:1184:1-11: WARNING: Use devm_platform_ioremap_resource for xadc -> base
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Manish Narani <manish.narani@xilinx.com>
Cc: Sven Van Asbroeck <thesven73@gmail.com>
---
drivers/iio/adc/xilinx-xadc-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
index 4fd389678dba..ec227b358cd6 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -1150,7 +1150,6 @@ static int xadc_probe(struct platform_device *pdev)
const struct of_device_id *id;
struct iio_dev *indio_dev;
unsigned int bipolar_mask;
- struct resource *mem;
unsigned int conf0;
struct xadc *xadc;
int ret;
@@ -1180,8 +1179,7 @@ static int xadc_probe(struct platform_device *pdev)
spin_lock_init(&xadc->lock);
INIT_DELAYED_WORK(&xadc->zynq_unmask_work, xadc_zynq_unmask_worker);
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- xadc->base = devm_ioremap_resource(&pdev->dev, mem);
+ xadc->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(xadc->base))
return PTR_ERR(xadc->base);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: xilinix-xadc: use devm_platform_ioremap_resource
2019-10-13 16:48 [PATCH] iio: adc: xilinix-xadc: use devm_platform_ioremap_resource jic23
@ 2019-10-14 19:56 ` Sven Van Asbroeck
2019-10-18 19:06 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Sven Van Asbroeck @ 2019-10-14 19:56 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Jonathan Cameron, Manish Narani
On Sun, Oct 13, 2019 at 12:50 PM <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Reduces local boilerplate.
> Suggested by coccinelle.
> CHECK drivers/iio/adc/xilinx-xadc-core.c
> drivers/iio/adc/xilinx-xadc-core.c:1184:1-11: WARNING: Use devm_platform_ioremap_resource for xadc -> base
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Manish Narani <manish.narani@xilinx.com>
> Cc: Sven Van Asbroeck <thesven73@gmail.com>
> ---
> drivers/iio/adc/xilinx-xadc-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Looks good to me:
Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: xilinix-xadc: use devm_platform_ioremap_resource
2019-10-14 19:56 ` Sven Van Asbroeck
@ 2019-10-18 19:06 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-10-18 19:06 UTC (permalink / raw)
To: Sven Van Asbroeck; +Cc: linux-iio, Jonathan Cameron, Manish Narani
On Mon, 14 Oct 2019 15:56:36 -0400
Sven Van Asbroeck <thesven73@gmail.com> wrote:
> On Sun, Oct 13, 2019 at 12:50 PM <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduces local boilerplate.
> > Suggested by coccinelle.
> > CHECK drivers/iio/adc/xilinx-xadc-core.c
> > drivers/iio/adc/xilinx-xadc-core.c:1184:1-11: WARNING: Use devm_platform_ioremap_resource for xadc -> base
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Manish Narani <manish.narani@xilinx.com>
> > Cc: Sven Van Asbroeck <thesven73@gmail.com>
> > ---
> > drivers/iio/adc/xilinx-xadc-core.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Looks good to me:
>
> Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
Applied,
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-18 19:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-13 16:48 [PATCH] iio: adc: xilinix-xadc: use devm_platform_ioremap_resource jic23
2019-10-14 19:56 ` Sven Van Asbroeck
2019-10-18 19:06 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox