From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: <linux-iio@vger.kernel.org>, Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio:accel:bma180: Fix the shared by parameter for an enum
Date: Wed, 8 Jul 2020 16:41:31 +0100 [thread overview]
Message-ID: <20200708164131.00000065@Huawei.com> (raw)
In-Reply-To: <20200707203044.369103-1-jic23@kernel.org>
On Tue, 7 Jul 2020 21:30:44 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Title on this one is gibberish. Let us pretend that says
Fix: Use enum value IIO_SHARED_BY_ALL instead of a boolean.
>
> This takes an enum, not a boolean. Discovered via warning when doing
> a W=1 build.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: fdadbce0da4 ("iio: add Bosch BMA180 acceleration sensor driver")
> ---
> drivers/iio/accel/bma180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index 5b7a467c7b27..3246a5ef7360 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
> };
>
> static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
> - IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
> + IIO_ENUM("power_mode", IIO_SHARED_BY_ALL, &bma180_power_mode_enum),
> IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
> { }
prev parent reply other threads:[~2020-07-08 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:30 [PATCH] iio:accel:bma180: Fix the shared by parameter for an enum Jonathan Cameron
2020-07-08 15:41 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708164131.00000065@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox