* [PATCH] iio:accel:bma180: Fix the shared by parameter for an enum
@ 2020-07-07 20:30 Jonathan Cameron
2020-07-08 15:41 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2020-07-07 20:30 UTC (permalink / raw)
To: linux-iio; +Cc: Peter Meerwald, Jonathan Cameron
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This takes an enum, not a boolean. Discovered via warning when doing
a W=1 build.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes: fdadbce0da4 ("iio: add Bosch BMA180 acceleration sensor driver")
---
drivers/iio/accel/bma180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 5b7a467c7b27..3246a5ef7360 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
};
static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
- IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
+ IIO_ENUM("power_mode", IIO_SHARED_BY_ALL, &bma180_power_mode_enum),
IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
{ }
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio:accel:bma180: Fix the shared by parameter for an enum
2020-07-07 20:30 [PATCH] iio:accel:bma180: Fix the shared by parameter for an enum Jonathan Cameron
@ 2020-07-08 15:41 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-07-08 15:41 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Peter Meerwald
On Tue, 7 Jul 2020 21:30:44 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Title on this one is gibberish. Let us pretend that says
Fix: Use enum value IIO_SHARED_BY_ALL instead of a boolean.
>
> This takes an enum, not a boolean. Discovered via warning when doing
> a W=1 build.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Fixes: fdadbce0da4 ("iio: add Bosch BMA180 acceleration sensor driver")
> ---
> drivers/iio/accel/bma180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index 5b7a467c7b27..3246a5ef7360 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
> };
>
> static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
> - IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
> + IIO_ENUM("power_mode", IIO_SHARED_BY_ALL, &bma180_power_mode_enum),
> IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
> { }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-08 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-07 20:30 [PATCH] iio:accel:bma180: Fix the shared by parameter for an enum Jonathan Cameron
2020-07-08 15:41 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox