public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio:dac:ad5592r: Fix use of true where iio_shared_by enum required
@ 2020-09-13 11:47 Jonathan Cameron
  2020-09-17 18:40 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2020-09-13 11:47 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron, Alexandru Ardelean

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Given true evaluates to 1, this should IIO_SHARED_BY_TYPE.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>
Fixes: 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
---
 drivers/iio/dac/ad5592r-base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
index cc4875660a69..456bf5292c44 100644
--- a/drivers/iio/dac/ad5592r-base.c
+++ b/drivers/iio/dac/ad5592r-base.c
@@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = {
 	{
 	 .name = "scale_available",
 	 .read = ad5592r_show_scale_available,
-	 .shared = true,
+	 .shared = IIO_SHARED_BY_TYPE,
 	 },
 	{},
 };
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio:dac:ad5592r: Fix use of true where iio_shared_by enum required
  2020-09-13 11:47 [PATCH] iio:dac:ad5592r: Fix use of true where iio_shared_by enum required Jonathan Cameron
@ 2020-09-17 18:40 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-09-17 18:40 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron, Alexandru Ardelean

On Sun, 13 Sep 2020 12:47:31 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Given true evaluates to 1, this should IIO_SHARED_BY_TYPE.
I sent this same one out before and then lost it.  I've picked that
version up as at was reviewed at that time.

Sorry for the noise.

Jonathan

> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Fixes: 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
> ---
>  drivers/iio/dac/ad5592r-base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
> index cc4875660a69..456bf5292c44 100644
> --- a/drivers/iio/dac/ad5592r-base.c
> +++ b/drivers/iio/dac/ad5592r-base.c
> @@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = {
>  	{
>  	 .name = "scale_available",
>  	 .read = ad5592r_show_scale_available,
> -	 .shared = true,
> +	 .shared = IIO_SHARED_BY_TYPE,
>  	 },
>  	{},
>  };


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-17 18:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-13 11:47 [PATCH] iio:dac:ad5592r: Fix use of true where iio_shared_by enum required Jonathan Cameron
2020-09-17 18:40 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox