* [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
@ 2020-09-13 12:12 Jonathan Cameron
2020-09-18 13:36 ` Lars-Peter Clausen
2020-09-18 19:10 ` Matt Ranostay
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-09-13 12:12 UTC (permalink / raw)
To: linux-iio
Cc: Jonathan Cameron, Oleksandr Kravchenko, Peter Meerwald,
Jonathan Bakker
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Given a value of 1 corresponds to IIO_SHARE_BY_TYPE I have replaced
it with that. Should cause no functional change.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Cc: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Jonathan Bakker <xc-racer2@live.ca>
---
drivers/iio/accel/bma180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 448faed001fd..6b74c2b04c15 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
};
static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
- IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
+ IIO_ENUM("power_mode", IIO_SHARED_BY_TYPE, &bma180_power_mode_enum),
IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
{ }
--
2.28.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
2020-09-13 12:12 [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum Jonathan Cameron
@ 2020-09-18 13:36 ` Lars-Peter Clausen
2020-09-19 12:13 ` Jonathan Cameron
2020-09-18 19:10 ` Matt Ranostay
1 sibling, 1 reply; 4+ messages in thread
From: Lars-Peter Clausen @ 2020-09-18 13:36 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio
Cc: Jonathan Cameron, Oleksandr Kravchenko, Peter Meerwald,
Jonathan Bakker
On 9/13/20 2:12 PM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Given a value of 1 corresponds to IIO_SHARE_BY_TYPE I have replaced
> it with that. Should cause no functional change.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Jonathan Bakker <xc-racer2@live.ca>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/iio/accel/bma180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index 448faed001fd..6b74c2b04c15 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
> };
>
> static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
> - IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
> + IIO_ENUM("power_mode", IIO_SHARED_BY_TYPE, &bma180_power_mode_enum),
> IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
> { }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
2020-09-18 13:36 ` Lars-Peter Clausen
@ 2020-09-19 12:13 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-09-19 12:13 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: linux-iio, Jonathan Cameron, Oleksandr Kravchenko, Peter Meerwald,
Jonathan Bakker
On Fri, 18 Sep 2020 15:36:58 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 9/13/20 2:12 PM, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Given a value of 1 corresponds to IIO_SHARE_BY_TYPE I have replaced
> > it with that. Should cause no functional change.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
> > Cc: Peter Meerwald <pmeerw@pmeerw.net>
> > Cc: Jonathan Bakker <xc-racer2@live.ca>
>
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks. Applied to the togreg branch of iio.git.
I haven't marked it for stable because it has not material affect.
Not a problem if it gets picked up anyway of course!
Thanks,
Jonathan
>
>
> > ---
> > drivers/iio/accel/bma180.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> > index 448faed001fd..6b74c2b04c15 100644
> > --- a/drivers/iio/accel/bma180.c
> > +++ b/drivers/iio/accel/bma180.c
> > @@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
> > };
> >
> > static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
> > - IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
> > + IIO_ENUM("power_mode", IIO_SHARED_BY_TYPE, &bma180_power_mode_enum),
> > IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
> > IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
> > { }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum
2020-09-13 12:12 [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum Jonathan Cameron
2020-09-18 13:36 ` Lars-Peter Clausen
@ 2020-09-18 19:10 ` Matt Ranostay
1 sibling, 0 replies; 4+ messages in thread
From: Matt Ranostay @ 2020-09-18 19:10 UTC (permalink / raw)
To: Jonathan Cameron
Cc: open list:IIO SUBSYSTEM AND DRIVERS, Jonathan Cameron,
Oleksandr Kravchenko, Peter Meerwald, Jonathan Bakker
On Sun, Sep 13, 2020 at 5:12 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Given a value of 1 corresponds to IIO_SHARE_BY_TYPE I have replaced
> it with that. Should cause no functional change.
>
Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: Jonathan Bakker <xc-racer2@live.ca>
> ---
> drivers/iio/accel/bma180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index 448faed001fd..6b74c2b04c15 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
> };
>
> static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
> - IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
> + IIO_ENUM("power_mode", IIO_SHARED_BY_TYPE, &bma180_power_mode_enum),
> IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
> IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
> { }
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-19 12:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-13 12:12 [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum Jonathan Cameron
2020-09-18 13:36 ` Lars-Peter Clausen
2020-09-19 12:13 ` Jonathan Cameron
2020-09-18 19:10 ` Matt Ranostay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox