public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 0/8] iio: cleanup some new instances of manual parent setting.
Date: Mon, 3 May 2021 12:37:05 +0100	[thread overview]
Message-ID: <20210503123705.5ecc355b@jic23-huawei> (raw)
In-Reply-To: <CA+U=DsoO6tK=y4LNFNsvqDSDTJgX6DHiTxMOR0fW+YEXUoG5pA@mail.gmail.com>

On Tue, 27 Apr 2021 10:27:44 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Mon, Apr 26, 2021 at 8:04 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > It seems I still haven't trained my eyes to spot these.
> >
> > I think they have all been introduced since
> > iio_device_alloc() and friends started setting this
> > 8525df47b3d1e ("iio: core: fix/re-introduce back parent assignment")
> > 78289b4a58b58 ("iio: core: pass parent device as parameter during allocation")
> >
> > Anyhow, all seem fairly obvious to me, but maybe I missed something so please
> > take a look.  
> 
> I've added 2 comments that are unrelated [directly] to this series.
> 
> Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Thanks for checking these.  I've added the of_node dropping bit
to the patch you pointed that out in.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it and see if we missed anything!

Thanks,

Jonathan

> 
> >
> > Jonathan Cameron (8):
> >   iio: accel: bmi088: Drop manual assignment of iio_dev.dev.parent
> >   iio: dac: ad5766: Drop duplicate setting of iio_dev.dev.parent
> >   iio: adc: mp2629: Drop duplicate setting iio_dev.dev.parent
> >   iio: adc: mt6360: Drop duplicate setting of iio_dev.dev.parent
> >   iio: adc: ti-ads131e08: Drop duplicate setting of iio_dev.dev.parent
> >   iio: humidity: hdc2010: Drop duplicate setting of iio_dev.dev.parent
> >   iio: position: hid-sensor-custom-intel-hinge: Drop duplicate parent
> >     setting.
> >   iio: common: scmi_sensors: Drop duplicate setting of
> >     iio_dev.dev.parent
> >
> >  drivers/iio/accel/bmi088-accel-core.c                | 1 -
> >  drivers/iio/adc/mp2629_adc.c                         | 1 -
> >  drivers/iio/adc/mt6360-adc.c                         | 1 -
> >  drivers/iio/adc/ti-ads131e08.c                       | 1 -
> >  drivers/iio/common/scmi_sensors/scmi_iio.c           | 1 -
> >  drivers/iio/dac/ad5766.c                             | 1 -
> >  drivers/iio/humidity/hdc2010.c                       | 1 -
> >  drivers/iio/position/hid-sensor-custom-intel-hinge.c | 1 -
> >  8 files changed, 8 deletions(-)
> >
> > --
> > 2.31.1
> >  


      reply	other threads:[~2021-05-03 11:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 17:02 [PATCH 0/8] iio: cleanup some new instances of manual parent setting Jonathan Cameron
2021-04-26 17:02 ` [PATCH 1/8] iio: accel: bmi088: Drop manual assignment of iio_dev.dev.parent Jonathan Cameron
2021-04-26 17:02 ` [PATCH 2/8] iio: dac: ad5766: Drop duplicate setting " Jonathan Cameron
2021-04-27  7:26   ` Alexandru Ardelean
2021-04-27 17:13     ` Jonathan Cameron
2021-04-26 17:02 ` [PATCH 3/8] iio: adc: mp2629: Drop duplicate setting iio_dev.dev.parent Jonathan Cameron
2021-04-26 17:02 ` [PATCH 4/8] iio: adc: mt6360: Drop duplicate setting of iio_dev.dev.parent Jonathan Cameron
2021-04-27  7:25   ` Alexandru Ardelean
2021-04-27  8:21     ` Jonathan Cameron
2021-04-26 17:02 ` [PATCH 5/8] iio: adc: ti-ads131e08: " Jonathan Cameron
2021-04-26 17:02 ` [PATCH 6/8] iio: humidity: hdc2010: " Jonathan Cameron
2021-04-26 17:02 ` [PATCH 7/8] iio: position: hid-sensor-custom-intel-hinge: Drop duplicate parent setting Jonathan Cameron
2021-04-26 17:02 ` [PATCH 8/8] iio: common: scmi_sensors: Drop duplicate setting of iio_dev.dev.parent Jonathan Cameron
2021-04-27  7:27 ` [PATCH 0/8] iio: cleanup some new instances of manual parent setting Alexandru Ardelean
2021-05-03 11:37   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503123705.5ecc355b@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=ardeleanalex@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox