Linux IIO development
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: linux-iio@vger.kernel.org
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Jonathan Cameron <jic23@kernel.org>
Subject: [PATCH 1/2] counter: intel-qep: Mark PM callbacks with __maybe_unused
Date: Fri, 11 Jun 2021 14:55:57 +0300	[thread overview]
Message-ID: <20210611115558.796338-1-jarkko.nikula@linux.intel.com> (raw)

Remove CONFIG_PM ifdef and mark PM callbacks with __maybe_unused.

Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
 drivers/counter/intel-qep.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/counter/intel-qep.c b/drivers/counter/intel-qep.c
index ab10ba33f46a..a8d3dccecc0f 100644
--- a/drivers/counter/intel-qep.c
+++ b/drivers/counter/intel-qep.c
@@ -473,8 +473,7 @@ static void intel_qep_remove(struct pci_dev *pci)
 	intel_qep_writel(qep, INTEL_QEPCON, 0);
 }
 
-#ifdef CONFIG_PM
-static int intel_qep_suspend(struct device *dev)
+static int __maybe_unused intel_qep_suspend(struct device *dev)
 {
 	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
 	struct intel_qep *qep = pci_get_drvdata(pdev);
@@ -486,7 +485,7 @@ static int intel_qep_suspend(struct device *dev)
 	return 0;
 }
 
-static int intel_qep_resume(struct device *dev)
+static int __maybe_unused intel_qep_resume(struct device *dev)
 {
 	struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
 	struct intel_qep *qep = pci_get_drvdata(pdev);
@@ -512,7 +511,6 @@ static int intel_qep_resume(struct device *dev)
 
 	return 0;
 }
-#endif
 
 static UNIVERSAL_DEV_PM_OPS(intel_qep_pm_ops,
 			    intel_qep_suspend, intel_qep_resume, NULL);
-- 
2.30.2


             reply	other threads:[~2021-06-11 11:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 11:55 Jarkko Nikula [this message]
2021-06-11 11:55 ` [PATCH 2/2] counter: intel-qep: Use to_pci_dev() helper Jarkko Nikula
2021-06-13 10:36   ` Andy Shevchenko
2021-06-13 11:08     ` Jonathan Cameron
2021-06-14  8:24     ` Jarkko Nikula
2021-06-14  8:57       ` Andy Shevchenko
2021-06-14  9:37         ` Uwe Kleine-König
2021-06-14 10:47           ` Jonathan Cameron
2021-06-14 11:10             ` Andy Shevchenko
2021-06-11 17:23 ` [PATCH 1/2] counter: intel-qep: Mark PM callbacks with __maybe_unused Jonathan Cameron
2021-06-12  0:45   ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210611115558.796338-1-jarkko.nikula@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox