From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 2/2] counter: intel-qep: Use to_pci_dev() helper
Date: Mon, 14 Jun 2021 11:24:46 +0300 [thread overview]
Message-ID: <839944ff-e4e3-86c1-8d53-abaf96fa9271@linux.intel.com> (raw)
In-Reply-To: <CAHp75VfBoOvGp7O3-WSWFuXGbQP0EbSQYaJi5B28oBkazkV8+w@mail.gmail.com>
On 6/13/21 1:36 PM, Andy Shevchenko wrote:
> On Fri, Jun 11, 2021 at 2:57 PM Jarkko Nikula
> <jarkko.nikula@linux.intel.com> wrote:
>>
>> Use to_pci_dev() helper instead of container_of(d, struct pci_dev, dev);
>
> ...
>
>> - struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
>> + struct pci_dev *pdev = to_pci_dev(dev);
>> struct intel_qep *qep = pci_get_drvdata(pdev);
>
> Why not change both lines to dev_get_drvdata()?
>
I thought it before and Uwe had a good point why it isn't necessarily a
good idea:
https://www.spinics.net/lists/linux-pwm/msg15325.html
Jarkko
next prev parent reply other threads:[~2021-06-14 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 11:55 [PATCH 1/2] counter: intel-qep: Mark PM callbacks with __maybe_unused Jarkko Nikula
2021-06-11 11:55 ` [PATCH 2/2] counter: intel-qep: Use to_pci_dev() helper Jarkko Nikula
2021-06-13 10:36 ` Andy Shevchenko
2021-06-13 11:08 ` Jonathan Cameron
2021-06-14 8:24 ` Jarkko Nikula [this message]
2021-06-14 8:57 ` Andy Shevchenko
2021-06-14 9:37 ` Uwe Kleine-König
2021-06-14 10:47 ` Jonathan Cameron
2021-06-14 11:10 ` Andy Shevchenko
2021-06-11 17:23 ` [PATCH 1/2] counter: intel-qep: Mark PM callbacks with __maybe_unused Jonathan Cameron
2021-06-12 0:45 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=839944ff-e4e3-86c1-8d53-abaf96fa9271@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox