From: Jonathan Cameron <jic23@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
andy.shevchenko@gmail.com, kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol
Date: Tue, 13 Jul 2021 18:47:54 +0100 [thread overview]
Message-ID: <20210713184754.07d4d7c5@jic23-huawei> (raw)
In-Reply-To: <20210709071727.2453536-1-sean@geanix.com>
On Fri, 9 Jul 2021 09:17:27 +0200
Sean Nyekjaer <sean@geanix.com> wrote:
> Fix this warning from kernel test robot:
> smatch warnings:
> drivers/iio/accel/fxls8962af-core.c:640
> fxls8962af_i2c_raw_read_errata3() error: uninitialized symbol 'ret'.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> Fixes: af959b7b96b8 ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
Applied to the fixes-togreg branch of iio.git
Thanks,
Jonathan
> ---
> Changes since v2:
> - add commit msg
>
> drivers/iio/accel/fxls8962af-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af-core.c
> index 078d87865fde..0019f1ea7df2 100644
> --- a/drivers/iio/accel/fxls8962af-core.c
> +++ b/drivers/iio/accel/fxls8962af-core.c
> @@ -637,7 +637,7 @@ static int fxls8962af_i2c_raw_read_errata3(struct fxls8962af_data *data,
> return ret;
> }
>
> - return ret;
> + return 0;
> }
>
> static int fxls8962af_fifo_transfer(struct fxls8962af_data *data,
prev parent reply other threads:[~2021-07-13 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 7:17 [PATCH v2] iio: accel: fxls8962af: fix potential use of uninitialized symbol Sean Nyekjaer
2021-07-13 17:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713184754.07d4d7c5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox