* [PATCH 15/54] dt-bindings: iio: st: Remove wrong items length check
[not found] <20210721140424.725744-1-maxime@cerno.tech>
@ 2021-07-21 14:03 ` Maxime Ripard
2021-07-23 21:47 ` Rob Herring
2021-07-23 22:45 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Maxime Ripard @ 2021-07-21 14:03 UTC (permalink / raw)
To: Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, devicetree,
Rob Herring, Frank Rowand
Cc: linux-arm-kernel, linux-sunxi, Denis Ciocca, Jonathan Cameron,
Lars-Peter Clausen, Linus Walleij, linux-iio
The original bindings was listing the length of the interrupts as either
1 or 2, depending on the setup. This is also what is enforced by the top
level schema.
However, that is further constrained with an if clause that require
exactly two interrupts, even though it might not make sense on those
devices or in some setups.
Let's remove the clause entirely.
Cc: Denis Ciocca <denis.ciocca@st.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-iio@vger.kernel.org
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
.../bindings/iio/st,st-sensors.yaml | 41 -------------------
1 file changed, 41 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
index b2a1e42c56fa..71de5631ebae 100644
--- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
+++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml
@@ -152,47 +152,6 @@ allOf:
maxItems: 1
st,drdy-int-pin: false
- - if:
- properties:
- compatible:
- enum:
- # Two intertial interrupts i.e. accelerometer/gyro interrupts
- - st,h3lis331dl-accel
- - st,l3g4200d-gyro
- - st,l3g4is-gyro
- - st,l3gd20-gyro
- - st,l3gd20h-gyro
- - st,lis2de12
- - st,lis2dw12
- - st,lis2hh12
- - st,lis2dh12-accel
- - st,lis331dl-accel
- - st,lis331dlh-accel
- - st,lis3de
- - st,lis3dh-accel
- - st,lis3dhh
- - st,lis3mdl-magn
- - st,lng2dm-accel
- - st,lps331ap-press
- - st,lsm303agr-accel
- - st,lsm303dlh-accel
- - st,lsm303dlhc-accel
- - st,lsm303dlm-accel
- - st,lsm330-accel
- - st,lsm330-gyro
- - st,lsm330d-accel
- - st,lsm330d-gyro
- - st,lsm330dl-accel
- - st,lsm330dl-gyro
- - st,lsm330dlc-accel
- - st,lsm330dlc-gyro
- - st,lsm9ds0-gyro
- - st,lsm9ds1-magn
- then:
- properties:
- interrupts:
- maxItems: 2
-
required:
- compatible
- reg
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 15/54] dt-bindings: iio: st: Remove wrong items length check
2021-07-21 14:03 ` [PATCH 15/54] dt-bindings: iio: st: Remove wrong items length check Maxime Ripard
@ 2021-07-23 21:47 ` Rob Herring
2021-07-23 22:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-07-23 21:47 UTC (permalink / raw)
To: Maxime Ripard
Cc: Jonathan Cameron, devicetree, Rob Herring, Denis Ciocca,
linux-arm-kernel, Jernej Skrabec, linux-sunxi, Linus Walleij,
linux-iio, Lars-Peter Clausen, Frank Rowand, Chen-Yu Tsai
On Wed, 21 Jul 2021 16:03:45 +0200, Maxime Ripard wrote:
> The original bindings was listing the length of the interrupts as either
> 1 or 2, depending on the setup. This is also what is enforced by the top
> level schema.
>
> However, that is further constrained with an if clause that require
> exactly two interrupts, even though it might not make sense on those
> devices or in some setups.
>
> Let's remove the clause entirely.
>
> Cc: Denis Ciocca <denis.ciocca@st.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../bindings/iio/st,st-sensors.yaml | 41 -------------------
> 1 file changed, 41 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 15/54] dt-bindings: iio: st: Remove wrong items length check
2021-07-21 14:03 ` [PATCH 15/54] dt-bindings: iio: st: Remove wrong items length check Maxime Ripard
2021-07-23 21:47 ` Rob Herring
@ 2021-07-23 22:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-07-23 22:45 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Jernej Skrabec,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Frank Rowand, Linux ARM, linux-sunxi, Denis Ciocca,
Jonathan Cameron, Lars-Peter Clausen, linux-iio
On Wed, Jul 21, 2021 at 4:05 PM Maxime Ripard <maxime@cerno.tech> wrote:
> The original bindings was listing the length of the interrupts as either
> 1 or 2, depending on the setup. This is also what is enforced by the top
> level schema.
>
> However, that is further constrained with an if clause that require
> exactly two interrupts, even though it might not make sense on those
> devices or in some setups.
>
> Let's remove the clause entirely.
>
> Cc: Denis Ciocca <denis.ciocca@st.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Oops this was too ambitious. Sorry about that.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-23 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210721140424.725744-1-maxime@cerno.tech>
2021-07-21 14:03 ` [PATCH 15/54] dt-bindings: iio: st: Remove wrong items length check Maxime Ripard
2021-07-23 21:47 ` Rob Herring
2021-07-23 22:45 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox