From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Matt Ranostay <matt.ranostay@konsulko.com>,
Magnus Damm <magnus.damm@gmail.com>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] iio: ABI: Document in_concentration_co2_scale
Date: Fri, 10 Sep 2021 11:47:33 +0100 [thread overview]
Message-ID: <20210910114733.0000446c@Huawei.com> (raw)
In-Reply-To: <YToGpTR0aJ97GxG0@smile.fi.intel.com>
On Thu, 9 Sep 2021 16:05:41 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Sep 09, 2021 at 11:45:37AM +0200, Jacopo Mondi wrote:
> > Document the 'in_concentration_co2_scale' standard IIO attribute.
>
> ...
>
> > +What: /sys/bus/iio/devices/iio:deviceX/in_concentration_co2_scale
>
> I don't know the history of the discussion about this attribute but it seems
> too specific to have in list of kinda generic ones.
>
> Shouldn't be rather air / gas / etc used instead of CO2?
>
I'm not following. The sensor is measuring c02 concentration (in the air) so
we need to call that out. Making it more general would mean we couldn't then
handle a sensor that had channels for c02 and oxygen for example.
We don't bother to distinguish the difference between concentration in gas or
liquid because it seemed unneeded. This is sort of similar to the fact we
don't distinguish gas temperature (say in a humidity sensor) from object temperature
in an IR thermometer. We could do so if there is a strong reason for it.
Using c02 as a modifier on a concentration channel is in line with how we
handled things like different light frequency ranges ir, visible, red, green, blue.
Jonathan
next prev parent reply other threads:[~2021-09-10 10:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 9:45 [PATCH v5 0/4] iio: chemical: Add Senseair Sunrise CO2 sensor Jacopo Mondi
2021-09-09 9:45 ` [PATCH v5 1/4] dt-bindings: iio: chemical: Document senseair,sunrise " Jacopo Mondi
2021-09-09 9:45 ` [PATCH v5 2/4] iio: ABI: docs: Document Senseair Sunrise ABI Jacopo Mondi
2021-09-09 9:45 ` [PATCH v5 3/4] iio: chemical: Add Senseair Sunrise 006-0-007 driver Jacopo Mondi
2021-09-09 12:04 ` Peter Rosin
2021-09-20 13:02 ` Jacopo Mondi
2021-09-09 13:01 ` Andy Shevchenko
2021-09-09 13:03 ` Andy Shevchenko
2021-09-11 15:12 ` Jonathan Cameron
2021-09-11 15:29 ` Jonathan Cameron
2021-09-09 9:45 ` [PATCH v5 4/4] iio: ABI: Document in_concentration_co2_scale Jacopo Mondi
2021-09-09 13:05 ` Andy Shevchenko
2021-09-10 10:47 ` Jonathan Cameron [this message]
2021-09-11 15:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910114733.0000446c@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox