From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Roan van Dijk <roan@protonic.nl>,
Tomasz Duszynski <tduszyns@gmail.com>,
Marc Titinger <mtitinger@baylibre.com>,
Matt Ranostay <mranostay@gmail.com>,
Johan Hovold <johan@kernel.org>,
Paresh Chaudhary <paresh.chaudhary@rockwellcollins.com>,
Navin Sankar Velliangiri <navin@linumiz.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Ludovic Tancerel <ludovic.tancerel@maplehightech.com>,
linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 01/13] iio: core: Use sysfs_emit()
Date: Thu, 16 Dec 2021 19:52:05 +0100 [thread overview]
Message-ID: <20211216185217.1054495-2-lars@metafoo.de> (raw)
In-Reply-To: <20211216185217.1054495-1-lars@metafoo.de>
sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it
knows about the sysfs buffer specifics and has some built-in checks for
size and alignment.
This patch converts the places in the IIO core that follow the pattern of
return s*printf(...)
to
return sysfs_emit(...)
This covers the new places that have been introduced where sprintf() is
used for formatting sysfs output since the last time this was done in
commit 83ca56b663cf ("iio: core: Use sysfs_emit() (trivial bits)").
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/iio/industrialio-buffer.c | 4 ++--
drivers/iio/industrialio-core.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index 94eb9f6cf128..f7721553a938 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -1383,9 +1383,9 @@ static ssize_t direction_show(struct device *dev,
switch (buffer->direction) {
case IIO_BUFFER_DIRECTION_IN:
- return sprintf(buf, "in\n");
+ return sysfs_emit(buf, "in\n");
case IIO_BUFFER_DIRECTION_OUT:
- return sprintf(buf, "out\n");
+ return sysfs_emit(buf, "out\n");
default:
return -EINVAL;
}
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 20d5178ca073..25144383865c 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -747,7 +747,7 @@ static ssize_t iio_read_channel_label(struct device *dev,
return indio_dev->info->read_label(indio_dev, this_attr->c, buf);
if (this_attr->c->extend_name)
- return sprintf(buf, "%s\n", this_attr->c->extend_name);
+ return sysfs_emit(buf, "%s\n", this_attr->c->extend_name);
return -EINVAL;
}
--
2.30.2
next prev parent reply other threads:[~2021-12-16 18:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 18:52 [PATCH 00/13] iio: Use sysfs_emit() Lars-Peter Clausen
2021-12-16 18:52 ` Lars-Peter Clausen [this message]
2021-12-16 18:52 ` [PATCH 02/13] iio: dmaengine-buffer: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 03/13] iio: ad7192: " Lars-Peter Clausen
2021-12-23 13:30 ` Jonathan Cameron
2021-12-16 18:52 ` [PATCH 04/13] iio: ad9523: " Lars-Peter Clausen
2021-12-23 13:32 ` Jonathan Cameron
2021-12-16 18:52 ` [PATCH 05/13] iio: as3935: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 06/13] iio: ina2xx-adc: sysfs_emit() Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 07/13] iio: lm3533: Use sysfs_emit() Lars-Peter Clausen
2021-12-17 9:14 ` Johan Hovold
2022-01-16 16:50 ` Jonathan Cameron
2021-12-16 18:52 ` [PATCH 08/13] iio: max31856: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 09/13] iio: max31865: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 10/13] iio: max9611: " Lars-Peter Clausen
2021-12-17 9:05 ` Jacopo Mondi
2021-12-17 9:17 ` Lars-Peter Clausen
2021-12-17 10:09 ` Jacopo Mondi
2021-12-16 18:52 ` [PATCH 11/13] iio: ms_sensors: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 12/13] iio: scd4x: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 13/13] iio: sps30: " Lars-Peter Clausen
2022-01-16 16:54 ` [PATCH 00/13] iio: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216185217.1054495-2-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=jacopo+renesas@jmondi.org \
--cc=jic23@kernel.org \
--cc=johan@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=ludovic.tancerel@maplehightech.com \
--cc=mranostay@gmail.com \
--cc=mtitinger@baylibre.com \
--cc=navin@linumiz.com \
--cc=paresh.chaudhary@rockwellcollins.com \
--cc=roan@protonic.nl \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox