From: Lars-Peter Clausen <lars@metafoo.de>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Roan van Dijk <roan@protonic.nl>,
Tomasz Duszynski <tduszyns@gmail.com>,
Marc Titinger <mtitinger@baylibre.com>,
Matt Ranostay <mranostay@gmail.com>,
Johan Hovold <johan@kernel.org>,
Paresh Chaudhary <paresh.chaudhary@rockwellcollins.com>,
Navin Sankar Velliangiri <navin@linumiz.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Ludovic Tancerel <ludovic.tancerel@maplehightech.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 10/13] iio: max9611: Use sysfs_emit()
Date: Fri, 17 Dec 2021 10:17:58 +0100 [thread overview]
Message-ID: <485ca749-57d4-89c6-d19e-05b1cf5fb108@metafoo.de> (raw)
In-Reply-To: <20211217090543.4w3n6nfxxbemqnhb@uno.localdomain>
On 12/17/21 10:05 AM, Jacopo Mondi wrote:
> Hi Lars-Peter,
>
> On Thu, Dec 16, 2021 at 07:52:14PM +0100, Lars-Peter Clausen wrote:
>> sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it
>> knows about the sysfs buffer specifics and has some built-in checks for
>> size and alignment.
>>
>> Use sysfs_emit() to format the custom `in_power_shunt_resistor` and
>> `in_current_shunt_resistor` device attributes of the max9611 driver.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Looks good, I just wonder if a dependency on the CONFIG_SYSFS symbol
> should now be added...
>
I don't think anything has changed in this regard. The function is
called from a sysfs attribute callback. If SYSFS is disabled the
callback will not be called. At the same time sysfs_emit() is stubbed
out when SYSFS is disabled, so no compile error either.
next prev parent reply other threads:[~2021-12-17 9:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 18:52 [PATCH 00/13] iio: Use sysfs_emit() Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 01/13] iio: core: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 02/13] iio: dmaengine-buffer: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 03/13] iio: ad7192: " Lars-Peter Clausen
2021-12-23 13:30 ` Jonathan Cameron
2021-12-16 18:52 ` [PATCH 04/13] iio: ad9523: " Lars-Peter Clausen
2021-12-23 13:32 ` Jonathan Cameron
2021-12-16 18:52 ` [PATCH 05/13] iio: as3935: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 06/13] iio: ina2xx-adc: sysfs_emit() Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 07/13] iio: lm3533: Use sysfs_emit() Lars-Peter Clausen
2021-12-17 9:14 ` Johan Hovold
2022-01-16 16:50 ` Jonathan Cameron
2021-12-16 18:52 ` [PATCH 08/13] iio: max31856: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 09/13] iio: max31865: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 10/13] iio: max9611: " Lars-Peter Clausen
2021-12-17 9:05 ` Jacopo Mondi
2021-12-17 9:17 ` Lars-Peter Clausen [this message]
2021-12-17 10:09 ` Jacopo Mondi
2021-12-16 18:52 ` [PATCH 11/13] iio: ms_sensors: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 12/13] iio: scd4x: " Lars-Peter Clausen
2021-12-16 18:52 ` [PATCH 13/13] iio: sps30: " Lars-Peter Clausen
2022-01-16 16:54 ` [PATCH 00/13] iio: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485ca749-57d4-89c6-d19e-05b1cf5fb108@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=johan@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=ludovic.tancerel@maplehightech.com \
--cc=mranostay@gmail.com \
--cc=mtitinger@baylibre.com \
--cc=navin@linumiz.com \
--cc=paresh.chaudhary@rockwellcollins.com \
--cc=roan@protonic.nl \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox