* [PATCH 04/31] iio: light: cm3605: changing LED_* from enum led_brightness to actual value [not found] <20220121165436.30956-1-sampaio.ime@gmail.com> @ 2022-01-21 16:54 ` Luiz Sampaio 2022-01-22 16:38 ` Jonathan Cameron 0 siblings, 1 reply; 2+ messages in thread From: Luiz Sampaio @ 2022-01-21 16:54 UTC (permalink / raw) To: Kevin Tsai, Jonathan Cameron, Lars-Peter Clausen Cc: linux-kernel, Luiz Sampaio, linux-iio The enum led_brightness, which contains the declaration of LED_OFF, LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports max_brightness. --- drivers/iio/light/cm3605.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/cm3605.c b/drivers/iio/light/cm3605.c index 50d34a98839c..f60db6cd9e6d 100644 --- a/drivers/iio/light/cm3605.c +++ b/drivers/iio/light/cm3605.c @@ -238,7 +238,7 @@ static int cm3605_probe(struct platform_device *pdev) /* Just name the trigger the same as the driver */ led_trigger_register_simple("cm3605", &cm3605->led); - led_trigger_event(cm3605->led, LED_FULL); + led_trigger_event(cm3605->led, 255); indio_dev->info = &cm3605_info; indio_dev->name = "cm3605"; @@ -255,7 +255,7 @@ static int cm3605_probe(struct platform_device *pdev) return 0; out_remove_trigger: - led_trigger_event(cm3605->led, LED_OFF); + led_trigger_event(cm3605->led, 0); led_trigger_unregister_simple(cm3605->led); out_disable_aset: gpiod_set_value_cansleep(cm3605->aset, 0); @@ -269,7 +269,7 @@ static int cm3605_remove(struct platform_device *pdev) struct iio_dev *indio_dev = platform_get_drvdata(pdev); struct cm3605 *cm3605 = iio_priv(indio_dev); - led_trigger_event(cm3605->led, LED_OFF); + led_trigger_event(cm3605->led, 0); led_trigger_unregister_simple(cm3605->led); gpiod_set_value_cansleep(cm3605->aset, 0); iio_device_unregister(indio_dev); @@ -283,7 +283,7 @@ static int __maybe_unused cm3605_pm_suspend(struct device *dev) struct iio_dev *indio_dev = dev_get_drvdata(dev); struct cm3605 *cm3605 = iio_priv(indio_dev); - led_trigger_event(cm3605->led, LED_OFF); + led_trigger_event(cm3605->led, 0); regulator_disable(cm3605->vdd); return 0; @@ -298,7 +298,7 @@ static int __maybe_unused cm3605_pm_resume(struct device *dev) ret = regulator_enable(cm3605->vdd); if (ret) dev_err(dev, "failed to enable regulator in resume path\n"); - led_trigger_event(cm3605->led, LED_FULL); + led_trigger_event(cm3605->led, 255); return 0; } -- 2.34.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 04/31] iio: light: cm3605: changing LED_* from enum led_brightness to actual value 2022-01-21 16:54 ` [PATCH 04/31] iio: light: cm3605: changing LED_* from enum led_brightness to actual value Luiz Sampaio @ 2022-01-22 16:38 ` Jonathan Cameron 0 siblings, 0 replies; 2+ messages in thread From: Jonathan Cameron @ 2022-01-22 16:38 UTC (permalink / raw) To: Luiz Sampaio; +Cc: Kevin Tsai, Lars-Peter Clausen, linux-kernel, linux-iio On Fri, 21 Jan 2022 13:54:09 -0300 Luiz Sampaio <sampaio.ime@gmail.com> wrote: > The enum led_brightness, which contains the declaration of LED_OFF, > LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports > max_brightness. No sign-off and please always cc everyone on the cover letter of a series including all mailing lists. Otherwise we have no visibility of the reasoning behind the change. We all need to see the cover letter. Sure I can go search for this patch on lore.kernel.org, but why make it hard :) Thanks, Jonathan > --- > drivers/iio/light/cm3605.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/light/cm3605.c b/drivers/iio/light/cm3605.c > index 50d34a98839c..f60db6cd9e6d 100644 > --- a/drivers/iio/light/cm3605.c > +++ b/drivers/iio/light/cm3605.c > @@ -238,7 +238,7 @@ static int cm3605_probe(struct platform_device *pdev) > > /* Just name the trigger the same as the driver */ > led_trigger_register_simple("cm3605", &cm3605->led); > - led_trigger_event(cm3605->led, LED_FULL); > + led_trigger_event(cm3605->led, 255); > > indio_dev->info = &cm3605_info; > indio_dev->name = "cm3605"; > @@ -255,7 +255,7 @@ static int cm3605_probe(struct platform_device *pdev) > return 0; > > out_remove_trigger: > - led_trigger_event(cm3605->led, LED_OFF); > + led_trigger_event(cm3605->led, 0); > led_trigger_unregister_simple(cm3605->led); > out_disable_aset: > gpiod_set_value_cansleep(cm3605->aset, 0); > @@ -269,7 +269,7 @@ static int cm3605_remove(struct platform_device *pdev) > struct iio_dev *indio_dev = platform_get_drvdata(pdev); > struct cm3605 *cm3605 = iio_priv(indio_dev); > > - led_trigger_event(cm3605->led, LED_OFF); > + led_trigger_event(cm3605->led, 0); > led_trigger_unregister_simple(cm3605->led); > gpiod_set_value_cansleep(cm3605->aset, 0); > iio_device_unregister(indio_dev); > @@ -283,7 +283,7 @@ static int __maybe_unused cm3605_pm_suspend(struct device *dev) > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct cm3605 *cm3605 = iio_priv(indio_dev); > > - led_trigger_event(cm3605->led, LED_OFF); > + led_trigger_event(cm3605->led, 0); > regulator_disable(cm3605->vdd); > > return 0; > @@ -298,7 +298,7 @@ static int __maybe_unused cm3605_pm_resume(struct device *dev) > ret = regulator_enable(cm3605->vdd); > if (ret) > dev_err(dev, "failed to enable regulator in resume path\n"); > - led_trigger_event(cm3605->led, LED_FULL); > + led_trigger_event(cm3605->led, 255); > > return 0; > } ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-22 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220121165436.30956-1-sampaio.ime@gmail.com>
2022-01-21 16:54 ` [PATCH 04/31] iio: light: cm3605: changing LED_* from enum led_brightness to actual value Luiz Sampaio
2022-01-22 16:38 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox