From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: Hennerich@vger.kernel.org, Michael <Michael.Hennerich@analog.com>,
Nuno Sa <Nuno.Sa@analog.com>,
lars@metafoo.de, Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v3 13/20] staging:iio:adc:ad7280a: Use a local dev pointer to avoid &spi->dev
Date: Sun, 6 Feb 2022 19:03:21 +0000 [thread overview]
Message-ID: <20220206190328.333093-14-jic23@kernel.org> (raw)
In-Reply-To: <20220206190328.333093-1-jic23@kernel.org>
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
We use this a few times already and it is about to get worse, so
introduce a local variable to simplify things.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
---
drivers/staging/iio/adc/ad7280a.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index 8635a12f5f84..df4a03f42c7a 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -955,11 +955,12 @@ static const struct ad7280_platform_data ad7793_default_pdata = {
static int ad7280_probe(struct spi_device *spi)
{
const struct ad7280_platform_data *pdata = dev_get_platdata(&spi->dev);
+ struct device *dev = &spi->dev;
struct ad7280_state *st;
int ret;
struct iio_dev *indio_dev;
- indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
+ indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
if (!indio_dev)
return -ENOMEM;
@@ -991,7 +992,7 @@ static int ad7280_probe(struct spi_device *spi)
st->aux_threshhigh = 0xFF;
st->acquisition_time = pdata->acquisition_time;
- ret = devm_add_action_or_reset(&spi->dev, ad7280_sw_power_down, st);
+ ret = devm_add_action_or_reset(dev, ad7280_sw_power_down, st);
if (ret)
return ret;
@@ -1020,7 +1021,7 @@ static int ad7280_probe(struct spi_device *spi)
if (ret)
return ret;
- ret = devm_request_threaded_irq(&spi->dev, spi->irq,
+ ret = devm_request_threaded_irq(dev, spi->irq,
NULL,
ad7280_event_handler,
IRQF_TRIGGER_FALLING |
@@ -1035,7 +1036,7 @@ static int ad7280_probe(struct spi_device *spi)
indio_dev->info = &ad7280_info_no_irq;
}
- return devm_iio_device_register(&spi->dev, indio_dev);
+ return devm_iio_device_register(dev, indio_dev);
}
static const struct spi_device_id ad7280_id[] = {
--
2.35.1
next prev parent reply other threads:[~2022-02-06 18:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 19:03 [PATCH v3 00/20] iio:adc:ad7280a Cleanup and proposed staging graduation Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 01/20] staging:iio:adc:ad7280a: Fix handing of device address bit reversing Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 02/20] staging:iio:adc:ad7280a: Register define cleanup Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 03/20] staging:iio:adc:ad7280a: rename _read() to _read_reg() Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 04/20] staging:iio:adc:ad7280a: Split buff[2] into tx and rx parts Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 05/20] staging:iio:adc:ad7280a: Use bitfield ops to managed fields in transfers Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 06/20] staging:iio:adc:ad7280a: Switch to standard event control Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 07/20] staging:iio:adc:ad7280a: Standardize extended ABI naming Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 08/20] staging:iio:adc:ad7280a: Drop unused timestamp channel Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 09/20] staging:iio:adc:ad7280a: Trivial comment formatting cleanup Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 10/20] staging:iio:adc:ad7280a: Make oversampling_ratio a runtime control Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 11/20] staging:iio:adc:ad7280a: Cleanup includes Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 12/20] staging:iio:ad7280a: Reflect optionality of irq in ABI Jonathan Cameron
2022-02-06 19:03 ` Jonathan Cameron [this message]
2022-02-06 19:03 ` [PATCH v3 14/20] staging:iio:adc:ad7280a: Use device properties to replace platform data Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 15/20] staging:iio:adc:ad7280a: Drop buggy support for early termination of AUX alert Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 16/20] dt-bindings:iio:adc:ad7280a: Add binding Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 17/20] iio:adc:ad7280a: Document ABI for cell balance switches Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 18/20] staging:iio:adc:ad7280a: Remove shift from cb_mask state cache Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 19/20] staging:iio:adc:ad7280a: Use more conservative delays to allow 105C operation Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 20/20] iio:adc:ad7280a: Move out of staging Jonathan Cameron
2022-02-13 20:11 ` [PATCH v3 00/20] iio:adc:ad7280a Cleanup and proposed staging graduation Marcelo Schmitt
2022-02-18 11:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220206190328.333093-14-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Hennerich@vger.kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox