From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: Hennerich@vger.kernel.org, Michael <Michael.Hennerich@analog.com>,
Nuno Sa <Nuno.Sa@analog.com>,
lars@metafoo.de, Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v3 04/20] staging:iio:adc:ad7280a: Split buff[2] into tx and rx parts
Date: Sun, 6 Feb 2022 19:03:12 +0000 [thread overview]
Message-ID: <20220206190328.333093-5-jic23@kernel.org> (raw)
In-Reply-To: <20220206190328.333093-1-jic23@kernel.org>
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
As the __cacheline_aligned will ensure that the first of these two buffers
is appropriate aligned, there is no need to keep them as a single array
which is confusing given the first element is always tx and the second
rx. Hence let us just have two parts and name them separately.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
---
drivers/staging/iio/adc/ad7280a.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index f1382666d2aa..b1698262cee0 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -153,7 +153,8 @@ struct ad7280_state {
unsigned char cb_mask[AD7280A_MAX_CHAIN];
struct mutex lock; /* protect sensor state */
- __be32 buf[2] ____cacheline_aligned;
+ __be32 tx ____cacheline_aligned;
+ __be32 rx;
};
static unsigned char ad7280_calc_crc8(unsigned char *crc_tab, unsigned int val)
@@ -196,18 +197,18 @@ static int __ad7280_read32(struct ad7280_state *st, unsigned int *val)
{
int ret;
struct spi_transfer t = {
- .tx_buf = &st->buf[0],
- .rx_buf = &st->buf[1],
- .len = 4,
+ .tx_buf = &st->tx,
+ .rx_buf = &st->rx,
+ .len = sizeof(st->tx),
};
- st->buf[0] = cpu_to_be32(AD7280A_READ_TXVAL);
+ st->tx = cpu_to_be32(AD7280A_READ_TXVAL);
ret = spi_sync_transfer(st->spi, &t, 1);
if (ret)
return ret;
- *val = be32_to_cpu(st->buf[1]);
+ *val = be32_to_cpu(st->rx);
return 0;
}
@@ -219,9 +220,9 @@ static int ad7280_write(struct ad7280_state *st, unsigned int devaddr,
(val & 0xFF) << 13 | all << 12;
reg |= ad7280_calc_crc8(st->crc_tab, reg >> 11) << 3 | 0x2;
- st->buf[0] = cpu_to_be32(reg);
+ st->tx = cpu_to_be32(reg);
- return spi_write(st->spi, &st->buf[0], 4);
+ return spi_write(st->spi, &st->tx, sizeof(st->tx));
}
static int ad7280_read_reg(struct ad7280_state *st, unsigned int devaddr,
--
2.35.1
next prev parent reply other threads:[~2022-02-06 18:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 19:03 [PATCH v3 00/20] iio:adc:ad7280a Cleanup and proposed staging graduation Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 01/20] staging:iio:adc:ad7280a: Fix handing of device address bit reversing Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 02/20] staging:iio:adc:ad7280a: Register define cleanup Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 03/20] staging:iio:adc:ad7280a: rename _read() to _read_reg() Jonathan Cameron
2022-02-06 19:03 ` Jonathan Cameron [this message]
2022-02-06 19:03 ` [PATCH v3 05/20] staging:iio:adc:ad7280a: Use bitfield ops to managed fields in transfers Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 06/20] staging:iio:adc:ad7280a: Switch to standard event control Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 07/20] staging:iio:adc:ad7280a: Standardize extended ABI naming Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 08/20] staging:iio:adc:ad7280a: Drop unused timestamp channel Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 09/20] staging:iio:adc:ad7280a: Trivial comment formatting cleanup Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 10/20] staging:iio:adc:ad7280a: Make oversampling_ratio a runtime control Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 11/20] staging:iio:adc:ad7280a: Cleanup includes Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 12/20] staging:iio:ad7280a: Reflect optionality of irq in ABI Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 13/20] staging:iio:adc:ad7280a: Use a local dev pointer to avoid &spi->dev Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 14/20] staging:iio:adc:ad7280a: Use device properties to replace platform data Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 15/20] staging:iio:adc:ad7280a: Drop buggy support for early termination of AUX alert Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 16/20] dt-bindings:iio:adc:ad7280a: Add binding Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 17/20] iio:adc:ad7280a: Document ABI for cell balance switches Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 18/20] staging:iio:adc:ad7280a: Remove shift from cb_mask state cache Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 19/20] staging:iio:adc:ad7280a: Use more conservative delays to allow 105C operation Jonathan Cameron
2022-02-06 19:03 ` [PATCH v3 20/20] iio:adc:ad7280a: Move out of staging Jonathan Cameron
2022-02-13 20:11 ` [PATCH v3 00/20] iio:adc:ad7280a Cleanup and proposed staging graduation Marcelo Schmitt
2022-02-18 11:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220206190328.333093-5-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Hennerich@vger.kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox