* [PATCH] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check
@ 2022-04-04 11:42 Dan Carpenter
2022-04-04 12:34 ` Sa, Nuno
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2022-04-04 11:42 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Michael Hennerich, Jonathan Cameron, linux-iio, Sa, Nuno,
kernel-janitors
The fwnode_get_named_child_node() function does not return error
pointers. It returns NULL. Update the check accordingly.
Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/iio/dac/ad3552r.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
index 97f13c0b9631..59f49b7564b2 100644
--- a/drivers/iio/dac/ad3552r.c
+++ b/drivers/iio/dac/ad3552r.c
@@ -809,10 +809,10 @@ static int ad3552r_configure_custom_gain(struct ad3552r_desc *dac,
gain_child = fwnode_get_named_child_node(child,
"custom-output-range-config");
- if (IS_ERR(gain_child)) {
+ if (!gain_child) {
dev_err(dev,
"mandatory custom-output-range-config property missing\n");
- return PTR_ERR(gain_child);
+ return -EINVAL;
}
dac->ch_data[ch].range_override = 1;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check
2022-04-04 11:42 [PATCH] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check Dan Carpenter
@ 2022-04-04 12:34 ` Sa, Nuno
2022-04-10 16:57 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Sa, Nuno @ 2022-04-04 12:34 UTC (permalink / raw)
To: Dan Carpenter, Lars-Peter Clausen
Cc: Hennerich, Michael, Jonathan Cameron, linux-iio@vger.kernel.org,
kernel-janitors@vger.kernel.org
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, April 4, 2022 1:43 PM
> To: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Jonathan
> Cameron <jic23@kernel.org>; linux-iio@vger.kernel.org; Sa, Nuno
> <Nuno.Sa@analog.com>; kernel-janitors@vger.kernel.org
> Subject: [PATCH] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check
>
> [External]
>
> The fwnode_get_named_child_node() function does not return error
> pointers. It returns NULL. Update the check accordingly.
>
> Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> drivers/iio/dac/ad3552r.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
> index 97f13c0b9631..59f49b7564b2 100644
> --- a/drivers/iio/dac/ad3552r.c
> +++ b/drivers/iio/dac/ad3552r.c
> @@ -809,10 +809,10 @@ static int
> ad3552r_configure_custom_gain(struct ad3552r_desc *dac,
>
> gain_child = fwnode_get_named_child_node(child,
> "custom-output-range-
> config");
> - if (IS_ERR(gain_child)) {
> + if (!gain_child) {
> dev_err(dev,
> "mandatory custom-output-range-config
> property missing\n");
> - return PTR_ERR(gain_child);
> + return -EINVAL;
> }
>
> dac->ch_data[ch].range_override = 1;
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check
2022-04-04 12:34 ` Sa, Nuno
@ 2022-04-10 16:57 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2022-04-10 16:57 UTC (permalink / raw)
To: Sa, Nuno
Cc: Dan Carpenter, Lars-Peter Clausen, Hennerich, Michael,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
On Mon, 4 Apr 2022 12:34:25 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> > Sent: Monday, April 4, 2022 1:43 PM
> > To: Lars-Peter Clausen <lars@metafoo.de>
> > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Jonathan
> > Cameron <jic23@kernel.org>; linux-iio@vger.kernel.org; Sa, Nuno
> > <Nuno.Sa@analog.com>; kernel-janitors@vger.kernel.org
> > Subject: [PATCH] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check
> >
> > [External]
> >
> > The fwnode_get_named_child_node() function does not return error
> > pointers. It returns NULL. Update the check accordingly.
> >
> > Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> > drivers/iio/dac/ad3552r.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
> > index 97f13c0b9631..59f49b7564b2 100644
> > --- a/drivers/iio/dac/ad3552r.c
> > +++ b/drivers/iio/dac/ad3552r.c
> > @@ -809,10 +809,10 @@ static int
> > ad3552r_configure_custom_gain(struct ad3552r_desc *dac,
> >
> > gain_child = fwnode_get_named_child_node(child,
> > "custom-output-range-
> > config");
> > - if (IS_ERR(gain_child)) {
> > + if (!gain_child) {
> > dev_err(dev,
> > "mandatory custom-output-range-config
> > property missing\n");
> > - return PTR_ERR(gain_child);
> > + return -EINVAL;
> > }
> >
> > dac->ch_data[ch].range_override = 1;
> > --
> > 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-10 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-04 11:42 [PATCH] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check Dan Carpenter
2022-04-04 12:34 ` Sa, Nuno
2022-04-10 16:57 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox