From: Gwendal Grignou <gwendal@chromium.org>
To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Gwendal Grignou <gwendal@chromium.org>
Subject: [PATCH v4 8/8] iio: sx9360: Add pre-charge resistor setting
Date: Wed, 6 Apr 2022 09:50:11 -0700 [thread overview]
Message-ID: <20220406165011.10202-9-gwendal@chromium.org> (raw)
In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org>
Add ability to set the precharge internal resistance from the device
tree.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes since v3:
- Added Review tags.
Changes since v2:
- Change kOhms into ohms.
Changes since v1:
- Suffix field with kOhms unit.
drivers/iio/proximity/sx9360.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/proximity/sx9360.c b/drivers/iio/proximity/sx9360.c
index 3ebb30c8a4f61..21cade4358aeb 100644
--- a/drivers/iio/proximity/sx9360.c
+++ b/drivers/iio/proximity/sx9360.c
@@ -51,6 +51,8 @@
#define SX9360_REG_GNRL_REG_2_FREQ(_r) (SX9360_FOSC_HZ / ((_r) * 8192))
#define SX9360_REG_AFE_CTRL1 0x21
+#define SX9360_REG_AFE_CTRL1_RESFILTIN_MASK GENMASK(3, 0)
+#define SX9360_REG_AFE_CTRL1_RESFILTIN_0OHMS 0
#define SX9360_REG_AFE_PARAM0_PHR 0x22
#define SX9360_REG_AFE_PARAM1_PHR 0x23
#define SX9360_REG_AFE_PARAM0_PHM 0x24
@@ -671,7 +673,7 @@ static const struct sx_common_reg_default sx9360_default_regs[] = {
{ SX9360_REG_GNRL_CTRL1, 0x00 },
{ SX9360_REG_GNRL_CTRL2, SX9360_REG_GNRL_CTRL2_PERIOD_102MS },
- { SX9360_REG_AFE_CTRL1, 0x00 },
+ { SX9360_REG_AFE_CTRL1, SX9360_REG_AFE_CTRL1_RESFILTIN_0OHMS },
{ SX9360_REG_AFE_PARAM0_PHR, SX9360_REG_AFE_PARAM0_RSVD |
SX9360_REG_AFE_PARAM0_RESOLUTION_128 },
{ SX9360_REG_AFE_PARAM1_PHR, SX9360_REG_AFE_PARAM1_AGAIN_PHM_6PF |
@@ -722,6 +724,14 @@ sx9360_get_default_reg(struct device *dev, int idx,
memcpy(reg_def, &sx9360_default_regs[idx], sizeof(*reg_def));
switch (reg_def->reg) {
+ case SX9360_REG_AFE_CTRL1:
+ ret = device_property_read_u32(dev,
+ "semtech,input-precharge-resistor-ohms",
+ &raw);
+ reg_def->def &= ~SX9360_REG_AFE_CTRL1_RESFILTIN_MASK;
+ reg_def->def |= FIELD_PREP(SX9360_REG_AFE_CTRL1_RESFILTIN_MASK,
+ raw / 2000);
+ break;
case SX9360_REG_AFE_PARAM0_PHR:
case SX9360_REG_AFE_PARAM0_PHM:
ret = device_property_read_u32(dev, "semtech,resolution", &raw);
--
2.35.1.1094.g7c7d902a7c-goog
prev parent reply other threads:[~2022-04-06 18:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 16:50 [PATCH v4 0/8] Add settings for precharge and internal resistor Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 1/8] iio: sx9324: Fix default precharge internal resistance register Gwendal Grignou
2022-04-06 17:14 ` Stephen Boyd
2022-04-10 16:49 ` Jonathan Cameron
2022-04-10 16:55 ` Jonathan Cameron
2022-04-06 16:50 ` [PATCH v4 2/8] iio: sx9324: Fix register field spelling Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 3/8] dt-bindings: iio: sx9324: Add precharge resistor setting Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 4/8] iio: sx9324: Add precharge internal resistance setting Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 5/8] dt-bindings: iio: sx9324: Add internal compensation resistor setting Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 6/8] iio: sx9324: Add Setting for internal compensation resistor Gwendal Grignou
2022-04-06 17:15 ` Stephen Boyd
2022-04-06 16:50 ` [PATCH v4 7/8] dt-bindings: iio: sx9360: Add precharge resistor setting Gwendal Grignou
2022-04-06 17:15 ` Stephen Boyd
2022-04-13 18:38 ` Rob Herring
2022-04-06 16:50 ` Gwendal Grignou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406165011.10202-9-gwendal@chromium.org \
--to=gwendal@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox