From: Gwendal Grignou <gwendal@chromium.org>
To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Gwendal Grignou <gwendal@chromium.org>,
stable@vger.kernel.org
Subject: [PATCH v4 1/8] iio: sx9324: Fix default precharge internal resistance register
Date: Wed, 6 Apr 2022 09:50:04 -0700 [thread overview]
Message-ID: <20220406165011.10202-2-gwendal@chromium.org> (raw)
In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org>
Fix the default value for the register that set the resistance:
it has to be 0x10 per datasheet.
Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support")
Cc: stable@vger.kernel.org
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
Changes since v3:
- Fix commit, use RESERVED instead of RSVD.
Changes since v2:
- no changes
Changes since v1:
- new patch.
drivers/iio/proximity/sx9324.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c
index 0d9bbbb50cb45..378c2a17bae6e 100644
--- a/drivers/iio/proximity/sx9324.c
+++ b/drivers/iio/proximity/sx9324.c
@@ -70,7 +70,8 @@
#define SX9324_REG_AFE_PH2 0x2a
#define SX9324_REG_AFE_PH3 0x2b
#define SX9324_REG_AFE_CTRL8 0x2c
-#define SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM 0x02
+#define SX9324_REG_AFE_CTRL8_RESERVED 0x10
+#define SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM 0x02
#define SX9324_REG_AFE_CTRL9 0x2d
#define SX9324_REG_AFE_CTRL9_AGAIN_1 0x08
@@ -781,7 +782,8 @@ static const struct sx_common_reg_default sx9324_default_regs[] = {
{ SX9324_REG_AFE_PH2, 0x1a },
{ SX9324_REG_AFE_PH3, 0x16 },
- { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM },
+ { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESERVED |
+ SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM },
{ SX9324_REG_AFE_CTRL9, SX9324_REG_AFE_CTRL9_AGAIN_1 },
{ SX9324_REG_PROX_CTRL0, SX9324_REG_PROX_CTRL0_GAIN_1 |
--
2.35.1.1094.g7c7d902a7c-goog
next prev parent reply other threads:[~2022-04-06 18:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 16:50 [PATCH v4 0/8] Add settings for precharge and internal resistor Gwendal Grignou
2022-04-06 16:50 ` Gwendal Grignou [this message]
2022-04-06 17:14 ` [PATCH v4 1/8] iio: sx9324: Fix default precharge internal resistance register Stephen Boyd
2022-04-10 16:49 ` Jonathan Cameron
2022-04-10 16:55 ` Jonathan Cameron
2022-04-06 16:50 ` [PATCH v4 2/8] iio: sx9324: Fix register field spelling Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 3/8] dt-bindings: iio: sx9324: Add precharge resistor setting Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 4/8] iio: sx9324: Add precharge internal resistance setting Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 5/8] dt-bindings: iio: sx9324: Add internal compensation resistor setting Gwendal Grignou
2022-04-06 16:50 ` [PATCH v4 6/8] iio: sx9324: Add Setting for internal compensation resistor Gwendal Grignou
2022-04-06 17:15 ` Stephen Boyd
2022-04-06 16:50 ` [PATCH v4 7/8] dt-bindings: iio: sx9360: Add precharge resistor setting Gwendal Grignou
2022-04-06 17:15 ` Stephen Boyd
2022-04-13 18:38 ` Rob Herring
2022-04-06 16:50 ` [PATCH v4 8/8] iio: sx9360: Add pre-charge " Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406165011.10202-2-gwendal@chromium.org \
--to=gwendal@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox