From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Navin Sankar Velliangiri <navin@linumiz.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties
Date: Sat, 16 Apr 2022 11:48:01 +0100 [thread overview]
Message-ID: <20220416114801.0865fcba@jic23-huawei> (raw)
In-Reply-To: <20220413185335.21743-1-andriy.shevchenko@linux.intel.com>
On Wed, 13 Apr 2022 21:53:35 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
This one should call out the addition of missing mod_devicetable.h
If nothing else comes up I can add that whilst applying.
Looks fine to me but I'd like to give a little time for
Navin to comment if they wish.
Jonathan
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iio/temperature/max31865.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/max31865.c b/drivers/iio/temperature/max31865.c
> index 86c3f3509a26..e3bb78184c6e 100644
> --- a/drivers/iio/temperature/max31865.c
> +++ b/drivers/iio/temperature/max31865.c
> @@ -12,9 +12,11 @@
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/init.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> +#include <linux/property.h>
> #include <linux/spi/spi.h>
> #include <asm/unaligned.h>
>
> @@ -305,7 +307,7 @@ static int max31865_probe(struct spi_device *spi)
> indio_dev->channels = max31865_channels;
> indio_dev->num_channels = ARRAY_SIZE(max31865_channels);
>
> - if (of_property_read_bool(spi->dev.of_node, "maxim,3-wire")) {
> + if (device_property_read_bool(&spi->dev, "maxim,3-wire")) {
> /* select 3 wire */
> data->three_wire = 1;
> } else {
next prev parent reply other threads:[~2022-04-16 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 18:53 [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties Andy Shevchenko
2022-04-16 10:48 ` Jonathan Cameron [this message]
2022-04-26 14:47 ` navin
2022-04-28 18:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220416114801.0865fcba@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navin@linumiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox