From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
kernel@pengutronix.de
Subject: Re: [PATCH] io:health:afe4404: Remove duplicated error reporting in .remove()
Date: Sun, 22 May 2022 21:58:42 +0200 [thread overview]
Message-ID: <20220522195842.edba7snapyefug76@pengutronix.de> (raw)
In-Reply-To: <20220514143812.1d2325e6@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
Hello Jonathan,
On Sat, May 14, 2022 at 02:38:12PM +0100, Jonathan Cameron wrote:
> On Sat, 14 May 2022 15:04:32 +0200
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > Returning an error value in an i2c remove callback results in an error
> > message being emitted by the i2c core, but otherwise it doesn't make a
> > difference.
> >
> > As afe4404_remove() already emits an error message on failure and the
> > additional error message by the i2c core doesn't add any useful
> > information, change the return value to zero to suppress this message.
> >
> > This patch is a preparation for making i2c remove callbacks return void.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Applied.
>
> Like the others this will sit in testing until I can rebase the togreg
> branch.
Don't know if it's to late to fix already, but I just noticed we'd want
s/io/iio/ in the Subject line.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-22 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 13:04 [PATCH] io:health:afe4404: Remove duplicated error reporting in .remove() Uwe Kleine-König
2022-05-14 13:38 ` Jonathan Cameron
2022-05-22 19:58 ` Uwe Kleine-König [this message]
2022-06-03 15:16 ` Jonathan Cameron
2022-06-03 15:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220522195842.edba7snapyefug76@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox